-
Notifications
You must be signed in to change notification settings - Fork 22
Conversation
Add Spectrum Scale support into the README
fix syntax issues
the same as IBM/ubiquity-k8s#257
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 3 files reviewed, 4 unresolved discussions (waiting on @deeghuge and @dima-i)
ibm-spectrum-scale.md, line 43 at r2 (raw file):
name: "pvc1" annotations: volume.beta.kubernetes.io/storage-class: "spectrumscale-primaryfs"
@deepak
please do not use this old annotation for storage class.
use storageClassName in the pvc spec instead.
ibm-spectrum-scale.md, line 46 at r2 (raw file):
spec: accessModes: - ReadWriteOnce # Ubiquity spectrum-scale backend supports ReadWriteOnce and ReadWriteMany mode.
why u r not showing RWmany? which is more scale orientated. up to you
ibm-spectrum-scale.md, line 141 at r2 (raw file):
#> cat storage-class-primaryfs.yml kind: StorageClass apiVersion: storage.k8s.io/v1beta1
please do not use beta (also in other places here)
check the helm storage class which is already aligned with it
ibm-spectrum-scale.md, line 287 at r2 (raw file):
```bash #> cat deployment1.yml apiVersion: "extensions/v1beta1"
dont use beta
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 3 files reviewed, 4 unresolved discussions (waiting on @shay-berman, @deeghuge, and @dima-i)
ibm-spectrum-scale.md, line 43 at r2 (raw file):
Previously, shay-berman wrote…
@deepak
please do not use this old annotation for storage class.
use storageClassName in the pvc spec instead.
Done
ibm-spectrum-scale.md, line 46 at r2 (raw file):
Previously, shay-berman wrote…
why u r not showing RWmany? which is more scale orientated. up to you
We are still looking for right usecase to show the RWM functionality with scale. As of now we dont have proper usecase to show this functionality. So for now we will keep these example and if in future we came up with good usecase we will add it.
ibm-spectrum-scale.md, line 141 at r2 (raw file):
Previously, shay-berman wrote…
please do not use beta (also in other places here)
check the helm storage class which is already aligned with it
done
ibm-spectrum-scale.md, line 287 at r2 (raw file):
Previously, shay-berman wrote…
dont use beta
done
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hi Deepak, your changes
Lets wait for Dima\Samuel approval and also for the new link to fix central before I will merge it to dev.
But please review it and provide your l-g-t-m if u think its ok
Reviewed 1 of 2 files at r1, 1 of 2 files at r2, 1 of 1 files at r3.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @shay-berman and @dima-i)
ibm-spectrum-scale.md, line 287 at r2 (raw file):
Previously, deeghuge (Deepak Ghuge) wrote…
done
its better to use
apiVersion: apps/v1
rather then extensions. check me out. and align it with what you think its better.
Apply Samuel comments and new URL to fix central
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 2 files at r4.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @dima-i)
I hope that this is the last merge to dev for v2.0.0 |
Align README file with version 2
related also to -> IBM/ubiquity#269
This change is