Skip to content
This repository has been archived by the owner on Jul 22, 2024. It is now read-only.

Add dependencies to glide.yaml to enable Docker's caching #224

Merged
merged 9 commits into from
Jul 16, 2018

Conversation

beckmani
Copy link
Contributor

@beckmani beckmani commented Jul 11, 2018

This change is Reviewable

@beckmani beckmani requested a review from shay-berman July 11, 2018 08:53
@coveralls
Copy link

Coverage Status

Coverage remained the same at 51.449% when pulling ab846b0 on align_glide_yaml into d7a5c54 on dev.

Copy link
Contributor

@shay-berman shay-berman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check comment below

other then that it :lgtm:

Reviewable status: 0 of 2 files reviewed, 1 unresolved discussion (waiting on @beckmani and @shay-berman)


glide.yaml, line 37 at r1 (raw file):

testImport:
- package: github.com/onsi/ginkgo
  version: v1.5.0

if you upgrade some package please state it in the PR
if there is specific reason why you choose a commit then please add comment in the line (if not then leave it as it)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants