Key value extraction improvements #1573
Merged
+77
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yoav Katz <katz@il.ibm.com>
Signed-off-by: Yoav Katz <katz@il.ibm.com>
Signed-off-by: Yoav Katz <katz@il.ibm.com>
Signed-off-by: Yoav Katz <katz@il.ibm.com>
Signed-off-by: Yoav Katz <katz@il.ibm.com>
Signed-off-by: Yoav Katz <katz@il.ibm.com>
Co-authored-by: Elron Bandel <elronbandel@gmail.com>
Signed-off-by: Yoav Katz <katz@il.ibm.com>
Signed-off-by: Yoav Katz <katz@il.ibm.com>
Signed-off-by: Yoav Katz <katz@il.ibm.com>
Signed-off-by: Yoav Katz <katz@il.ibm.com>
Signed-off-by: Yoav Katz <katz@il.ibm.com>
Signed-off-by: Yoav Katz <katz@il.ibm.com>
elronbandel
approved these changes
Feb 6, 2025
dafnapension
pushed a commit
that referenced
this pull request
Feb 6, 2025
* Added example for image key value extraction evaluation Signed-off-by: Yoav Katz <katz@il.ibm.com> * Removed unneeded comments Signed-off-by: Yoav Katz <katz@il.ibm.com> * Model key value extraction as a first class task in catalog Signed-off-by: Yoav Katz <katz@il.ibm.com> * Added documentation link Signed-off-by: Yoav Katz <katz@il.ibm.com> * Added default template to extraction task Signed-off-by: Yoav Katz <katz@il.ibm.com> * Changed order of results printout for clarity Signed-off-by: Yoav Katz <katz@il.ibm.com> * Update docs/docs/examples.rst Co-authored-by: Elron Bandel <elronbandel@gmail.com> * Ensure key values are strings as expected by the metric Signed-off-by: Yoav Katz <katz@il.ibm.com> * Moved to more standard font across Linux and Mac Signed-off-by: Yoav Katz <katz@il.ibm.com> * Moved to default font Signed-off-by: Yoav Katz <katz@il.ibm.com> * Doc improvements Signed-off-by: Yoav Katz <katz@il.ibm.com> * Improved parsing and testing of processing. Signed-off-by: Yoav Katz <katz@il.ibm.com> * Changed key value extraction to use json serializer Signed-off-by: Yoav Katz <katz@il.ibm.com> --------- Signed-off-by: Yoav Katz <katz@il.ibm.com> Co-authored-by: Elron Bandel <elronbandel@gmail.com>
dafnapension
pushed a commit
that referenced
this pull request
Feb 6, 2025
* Added example for image key value extraction evaluation Signed-off-by: Yoav Katz <katz@il.ibm.com> * Removed unneeded comments Signed-off-by: Yoav Katz <katz@il.ibm.com> * Model key value extraction as a first class task in catalog Signed-off-by: Yoav Katz <katz@il.ibm.com> * Added documentation link Signed-off-by: Yoav Katz <katz@il.ibm.com> * Added default template to extraction task Signed-off-by: Yoav Katz <katz@il.ibm.com> * Changed order of results printout for clarity Signed-off-by: Yoav Katz <katz@il.ibm.com> * Update docs/docs/examples.rst Co-authored-by: Elron Bandel <elronbandel@gmail.com> * Ensure key values are strings as expected by the metric Signed-off-by: Yoav Katz <katz@il.ibm.com> * Moved to more standard font across Linux and Mac Signed-off-by: Yoav Katz <katz@il.ibm.com> * Moved to default font Signed-off-by: Yoav Katz <katz@il.ibm.com> * Doc improvements Signed-off-by: Yoav Katz <katz@il.ibm.com> * Improved parsing and testing of processing. Signed-off-by: Yoav Katz <katz@il.ibm.com> * Changed key value extraction to use json serializer Signed-off-by: Yoav Katz <katz@il.ibm.com> --------- Signed-off-by: Yoav Katz <katz@il.ibm.com> Co-authored-by: Elron Bandel <elronbandel@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improved handling of literal vs json conversion, improved error testing .
In the previous version the references were printed as python dict implementation, while the model returned json format. There is a difference between the two formats (one uses single quotes and one double quotes, one uses "None" and one uses. "null").
Now we serialize the dict as json in the template, so the post processing is more consistent.