Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating perplexity computation, to apply exp(-x) #534

Merged
merged 6 commits into from
Jan 31, 2024
Merged

Updating perplexity computation, to apply exp(-x) #534

merged 6 commits into from
Jan 31, 2024

Conversation

assaftibm
Copy link
Member

No description provided.

Signed-off-by: Assaf Toledo <assaf.toledo@ibm.com>
Signed-off-by: Assaf Toledo <assaf.toledo@ibm.com>
Signed-off-by: Assaf Toledo <assaf.toledo@ibm.com>
Copy link

codecov bot commented Jan 30, 2024

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (3a7d719) 93.93% compared to head (0544e51) 93.93%.

Files Patch % Lines
src/unitxt/metrics.py 90.00% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #534   +/-   ##
=======================================
  Coverage   93.93%   93.93%           
=======================================
  Files         207      207           
  Lines        8010     8010           
=======================================
  Hits         7524     7524           
  Misses        486      486           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@assaftibm assaftibm requested a review from matanor January 30, 2024 22:34
Copy link
Member

@matanor matanor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@assaftibm assaftibm merged commit 4b3a923 into main Jan 31, 2024
5 of 6 checks passed
@assaftibm assaftibm deleted the pr_fix branch January 31, 2024 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants