structured data operators for serializing tablerows, triples and keyvalue pairs added #589
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
csrajmohan
commented
Feb 20, 2024
csrajmohan
commented
- Added new serialization operators for structured data: Table rows, Triples & KeyValue pairs
- Renamed table_operators -> struct_data_operators so that it best captures all structured data operators like the ones for Tables, Triples etc. and makes better sense to add other structured data operators to this in future.
- Added 3 new datatask cards to validate new operators
- wiki_bio : KeyValue Pair to Text(Data2Text task), Uses KeyValuePairs Serializer
- dart : Triples to Text(Data2Text task), Uses TriplesSerializer
- tablerow_classify : Table row classification using a Kaggle dataset(Heart disease prediction), Uses TableRowSerializer
csrajmohan
force-pushed
the
structured_data_operators
branch
from
f061516 to
4b8fd85
Compare
elronbandel
reviewed
Feb 21, 2024
prepare/cards/tablerow_classify.py
Outdated
| MapInstanceValues(mappers={"label": {"0": "Normal", "1": "Heart Disease"}}), | ||
| AddFields( | ||
| fields={ | ||
| "text_type": "Person", |
There was a problem hiding this comment.
Suggested change
| "text_type": "Person", | |
| "text_type": "person medical record", |
I think it is more descrptive, no?
elronbandel
reviewed
Feb 21, 2024
prepare/tasks/generation.py
Outdated
| @@ -3,7 +3,7 @@ | |||
|
|
|||
| add_to_catalog( | |||
| FormTask( | |||
| inputs=["input"], | |||
| inputs=["input", "type_of_input"], | |||
There was a problem hiding this comment.
Maybe would be also good to have type of output?
Suggested change
| inputs=["input", "type_of_input"], | |
| inputs=["input", "type_of_input", "type_of_output"], |
elronbandel
requested changes
Feb 21, 2024
|
In case its needed: the test is currently failing because of import from |
|
import for test file fixed |
elronbandel
force-pushed
the
structured_data_operators
branch
from
87f1d9a to
19d1f8d
Compare
…ange Signed-off-by: Rajmohan <rajmohanc1@in.ibm.com>
csrajmohan
force-pushed
the
structured_data_operators
branch
from
19d1f8d to
493ad02
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #589 +/- ##
==========================================
+ Coverage 88.38% 88.46% +0.08%
==========================================
Files 87 87
Lines 7698 7779 +81
==========================================
+ Hits 6804 6882 +78
- Misses 894 897 +3 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.