-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add filtered ffqa dataset #593
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #593 +/- ##
=======================================
Coverage 88.46% 88.46%
=======================================
Files 87 87
Lines 7779 7779
=======================================
Hits 6882 6882
Misses 897 897 ☔ View full report in Codecov by Sentry. |
@elronbandel - why does the catalog preparation this fail with: |
The failure due to the fact that the this is merge from a fork. We will handle this. |
Issue is now fixed @marukaz . Notice i rebased your branch to re-run the tests. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really cool contribution! This dataset will be very hard to incorpirate to unitxt without the creativity you showed with the ExcuteExpression! so thank you! If you can change the things i asked it will be great. let me know when your ready and ill merge.
Co-authored-by: Elron Bandel <elronbandel@gmail.com>
@elronbandel Thank you for your review! I updated code. |
catalog preparation test is failing but when I tried |
Add WikiQA-Free_Form_QA dataset, a long context QA dataset.
This dataset is formatted to be used in chat format, but I want to experiment with 8k context LLM, so I implemented preprocess_steps accordingly.