Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move test to subdir library #623

Merged
merged 1 commit into from
Mar 4, 2024
Merged

Move test to subdir library #623

merged 1 commit into from
Mar 4, 2024

Conversation

matanor
Copy link
Member

@matanor matanor commented Mar 4, 2024

Move the test added in the remote metrics PR to the correct directory

Copy link

codecov bot commented Mar 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.01%. Comparing base (f3745a9) to head (43a6a27).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #623      +/-   ##
==========================================
+ Coverage   88.00%   89.01%   +1.00%     
==========================================
  Files          87       88       +1     
  Lines        8031     8091      +60     
==========================================
+ Hits         7068     7202     +134     
+ Misses        963      889      -74     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@matanor matanor requested a review from elronbandel March 4, 2024 13:30
@matanor matanor enabled auto-merge (rebase) March 4, 2024 13:31
@matanor matanor merged commit a38cfb2 into main Mar 4, 2024
6 of 7 checks passed
@elronbandel elronbandel deleted the fix_metric_service_test_dir branch April 8, 2024 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants