This repository has been archived by the owner on Jul 22, 2024. It is now read-only.
T2C intent and entity value list block fix #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marek-danel
force-pushed
the
marek
branch
5 times, most recently
from
2841141 to
1cc3b9e
Compare
marek-danel
commented
May 31, 2018
marek-danel
force-pushed
the
marek
branch
4 times, most recently
from
1645f97 to
59f0d2f
Compare
marek-danel
commented
Jun 4, 2018
marek-danel
commented
Jun 4, 2018
marek-danel
commented
Jun 4, 2018
marek-danel
commented
Jun 4, 2018
marek-danel
commented
Jun 4, 2018
marek-danel
commented
Jun 4, 2018
marek-danel
commented
Jun 4, 2018
marek-danel
commented
Jun 4, 2018
marek-danel
commented
Jun 4, 2018
marek-danel
commented
Jun 4, 2018
marek-danel
commented
Jun 4, 2018
marek-danel
commented
Jun 4, 2018
marek-danel
commented
Jun 4, 2018
marek-danel
commented
Jun 4, 2018
tomasmacek
reviewed
Jun 4, 2018
|
@marek-danel adding@Tereza-Pytelova a @ondrejtomas to list of reviewers as it is bigger change impacting CI and testing |
|
Postponing this to the next sprint. |
|
Postponing this to the next sprint. |
|
@tomasmacek I'm postponing this to the Sprint 27. |
|
@tomasmacek we should either delete this or merge it. |
tomasmacek
reviewed
Mar 5, 2019
tomasmacek
reviewed
Mar 5, 2019
Tereza-Pytelova
approved these changes
Mar 5, 2019
Tereza-Pytelova
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
T2C was not creating nodes for conditions with following stucture (without any error):
#myIntent && @entity:()
entity_value1 response1
entity_value2 response2
The solution was embedding Adam's old but working scripts to latest version of WAW.
I managed to make it work together with current WAW. However, there might be some small changes lost by copying over old files. Can I make sure everything works fine by running some tests?
There are also some minor fixes and error output enhancements.