Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

We should have a short key for the build-command #79

Closed
joergboe opened this issue Jun 2, 2020 · 4 comments · Fixed by #90
Closed

We should have a short key for the build-command #79

joergboe opened this issue Jun 2, 2020 · 4 comments · Fixed by #90
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@joergboe
Copy link
Member

joergboe commented Jun 2, 2020

We should have a short key for the build-command and for the build-and-submit-command, because these command are very often used during development process.

@queeniema queeniema added the enhancement New feature or request label Jun 2, 2020
@queeniema
Copy link
Contributor

queeniema commented Jun 2, 2020

In VS Code, you can manually assign keyboard shortcuts to those commands. Documentation here.

Screen Shot 2020-06-02 at 8 38 21 AM

We could have shortcuts predefined in the extension. Do you have any suggestions for good shortcut combinations? We do not want the shortcuts to conflict with any of the built-in VS Code shortcuts (e.g., we should not use cmd+b for build because that is already used to toggle the side bar visibility).

@queeniema queeniema linked a pull request Jun 8, 2020 that will close this issue
@queeniema
Copy link
Contributor

We've decided to use the following keyboard shortcuts:

OS Build shortcut Build and Submit Job shortcut Screenshot
Windows Ctrl+Alt+B Ctrl+Alt+S windows
Linux Ctrl+Alt+B Ctrl+Alt+S linux
macOS Command+Option+B Command+Option+S mac

@joergboe
Copy link
Member Author

It seems not to work on a RHEL Client.

@queeniema
Copy link
Contributor

@joergboe I tried this in a RHEL 8.2 environment and it is working fine for me. Do you see the new keyboard shortcut keys next to build commands in the context menu (i.e.., Alt+Ctrl+B / Alt+Ctrl+S)?

Screen Shot 2020-06-19 at 3 10 11 PM

@queeniema queeniema added this to the v1.0.2 milestone Jul 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants