Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG]: Depends on vulnerable version of puppeteer #1959

Closed
poolcvs opened this issue Jul 25, 2024 · 3 comments
Closed

[BUG]: Depends on vulnerable version of puppeteer #1959

poolcvs opened this issue Jul 25, 2024 · 3 comments
Assignees
@shunguoy
Labels
Bug Something isn't working node-accessibility-checker Issues in the accessibility-checker component T63 user-reported Issues identified outside of the core team

Comments

@poolcvs
Copy link

poolcvs commented Jul 25, 2024

Project

extension-checker, accessibility-checker for Node

Browser

No response

Operating system

MacOS, Windows

Description

Expect no vulnerablilities reported on “npm update”. Got:

accessibility-checker  3.1.24-rc.0 - 3.1.73
Depends on vulnerable versions of puppeteer
node_modules/accessibility-checker

Steps to reproduce

Run “npm update” with latest version of accessibility-checker as a dependency.
@MHoov MHoov added node-accessibility-checker Issues in the accessibility-checker component user-reported Issues identified outside of the core team labels Jul 25, 2024
@shunguoy
Copy link
Contributor

shunguoy commented Jul 28, 2024 •
edited by marcjohlic
Loading

this should be fixed with this pull request: #1960
the puppeteer was updated to the latest.

@shunguoy shunguoy added the T62 label Jul 28, 2024
@MHoov MHoov added the Bug Something isn't working label Aug 16, 2024
@MHoov
Copy link

MHoov commented Aug 19, 2024

Waiting for #1960 to be approved and moved to production

@shunguoy shunguoy added T63 and removed T62 labels Aug 22, 2024
@shunguoy
Copy link
Contributor

The update of the Puppeteer version requires a large change in the code base, which will be done in the coming version 4 release.

@philljenkins philljenkins mentioned this issue Aug 30, 2024
Open
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@shunguoy shunguoy

Labels
Bug Something isn't working node-accessibility-checker Issues in the accessibility-checker component T63 user-reported Issues identified outside of the core team
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@shunguoy @MHoov @poolcvs