Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Puppeteer version & when? v13 fails to detect some CSS related issues/rules, v20 handles correctly. Decide when to upgrade to which version. #2022

Open
3 tasks
philljenkins opened this issue Aug 29, 2024 · 4 comments
Open
3 tasks

Puppeteer version & when? v13 fails to detect some CSS related issues/rules, v20 handles correctly. Decide when to upgrade to which version. #2022

philljenkins opened this issue Aug 29, 2024 · 4 comments
Assignees
@shunguoy @tombrunet

Comments

@philljenkins
Copy link
Contributor

v13 Puppeteer rules on current repo build
v20 Puppeteer latest

When should repo upgrade?

  • now if available?
  • later when moving to v4 of Checker
  • which version should we upgrade to?

Background

Checker element_orientation_unlocked rule covers 11 of 12 ACT test cases. Test case from "Failed Example 4" is incorrectly or correctly marked as inapplicable or fail depending on which v of Puppeteer is running. Also conflicts with results from running Checker in Chrome DevTools vs Puppeteer. Puppeteer includes Chrome, but v13 seems to override CSS (bug).

ACT ruleID b33eff

Failed Example 4 Open in a new tab
A page where the CSS rotate property has a 90 degree rotation conditionally applied on the orientation media feature which restricts the element to landscape orientation.

<html lang="en">
	<head>
		<title>Page with some content</title>
		<style>
			@media (orientation: portrait) {
				html {
					rotate: 90deg;
					width: min(100vw, 100vh);
					height: min(100vw, 100vh);
				}
			}
		</style>
	</head>
	<body>
		Page Content
	</body>
</html>

Checker ACT results returns the following for

  • Expected failed, but returned earl:inapplicable when running v13
  • Results logs the following:
   Failed Example 4: https://www.w3.org/WAI/content-assets/wcag-act-rules/testcases/b33eff/8f341a73c698daf157613c32a521878ed5aa7310.html
   [31m--Expected failed, but returned earl:inapplicable
   Failures: []
    Review: []
    Pass: []
    All: [
      "html_skipnav_exists:Potential_1:POTENTIAL",
      "style_highcontrast_visible:Manual_1:MANUAL",
      "skip_main_exists:Fail_1:FAIL"
@philljenkins philljenkins changed the title Puppeteer version. v13 fails to detect some CSS related issues/rules, v20 handles correctly. Decide when to upgrade to which version? Puppeteer version? v13 fails to detect some CSS related issues/rules, v20 handles correctly. Decide when to upgrade to which version? Aug 30, 2024
@philljenkins philljenkins changed the title Puppeteer version? v13 fails to detect some CSS related issues/rules, v20 handles correctly. Decide when to upgrade to which version? Puppeteer version & when? v13 fails to detect some CSS related issues/rules, v20 handles correctly. Decide when to upgrade to which version. Aug 30, 2024
@philljenkins
Copy link
Contributor Author

The update of the Puppeteer version requires a large change in the code base, which will be done in the coming version 4 release.

Originally posted by @shunguoy in #1959

@MHoov
Copy link

MHoov commented Aug 30, 2024

@tombrunet I believe version 4 release is not in scope for R6.3, is that correct?

@philljenkins
Copy link
Contributor Author

philljenkins commented Aug 30, 2024 •
edited
Loading

That is the crux of this issue, to decide to upgrade now to a possible version, but less impact, or wait till 4 release.

@shunguoy Did you find an earlier, less impactful, version of Puppeteer that might be an option to use IF we don't wait until v4 release?

@shunguoy
Copy link
Contributor

shunguoy commented Sep 9, 2024

Triage: wait for Version 4 of the checker, including puppeteer v20+.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@shunguoy shunguoy

@tombrunet tombrunet

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@philljenkins @shunguoy @tombrunet @MHoov