Possible isTabbable failure when we have a field set

[aliunwala]

[aliunwala]

Triage:
From our memory, what this issue was revolving around was that the isTabbable function makes all 3 radio button's tabbable and that is OKAY from a rules standpoint. But NOT okay from a visualization standpoint, as when you actually tab over each of the radio buttons you only tab to the first one.

[MHoov]

This is for keyboard checking mode. But Tom suspects this is an Engine problem and may need to wait for Shunguo.

[tombrunet]

Testcase:

<fieldset>
  <label><input name="rChk" type="radio">One</label><br/>
  <label><input name="rChk" type="radio">Two</label><br/>
  <label><input name="rChk" type="radio">Three</label><br/>
  <label><input name="rChk" type="radio">Four</label><br/>
</fieldset>

The issue here is that for a radio group, only one of the radio items is actually tabbable, but KCM shows all of them as tabbable because of the rule that detects tabbable.

• If no items are selected, only the first of the group is tabbable
• If an item is selected, only the selected item is tabbable.

Should this look at isTabbable in general for this scenario, or just the rule used by KCM?

[shunguoy]

#959 also https://github.com/focus-trap/tabbable/blob/master/src/index.js