Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(engine): update the isTabbable method for radio groups #2201

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

fix(engine): update the isTabbable method for radio groups #2201

wants to merge 3 commits into from

Conversation

shunguoy
Copy link
Contributor

@shunguoy shunguoy commented Feb 17, 2025 •
edited
Loading

  • Engine: update the isTabbable method for radio groups

This PR is related to the following issue(s):

Testing reference:

  • test case: test/v2/checker/accessibility/rules/widget_tabbable_single_ruleunit/fieldset.html
  • (1) Install the extension, (2) open the test case page in a browser; (3) scan the page; (4) launch the keyboard mode
    Before the fix, all the radio boxes were marked as 'tabbable' (see the original issue for a screenshot); after the fix, only one radio is marked as tabbable.

I have conducted the following for this PR:

  • I validated this code in Chrome and FF
  • I validated this fix in my local env
  • I provided details for testing
  • [] This PR has been reviewed and is ready for test
  • I understand that the title of this PR will be used for the next release notes.

Assets to aide review attached

  • Links to design artifacts
  • Links to video walkthrough of user experience
  • Other

Definition of Done

  • Peer review complete
  • Secondary review complete
  • Staging deployment verified

@shunguoy shunguoy assigned tombrunet and philljenkins and unassigned shunguoy Feb 19, 2025
@shunguoy shunguoy marked this pull request as ready for review February 19, 2025 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tombrunet tombrunet tombrunet approved these changes

Assignees

@philljenkins philljenkins

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Possible isTabbable failure when we have a field set
3 participants
@shunguoy @tombrunet @philljenkins