Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Volcano_Plot #440

Merged
merged 16 commits into from
Jan 31, 2025
Merged

Volcano_Plot #440

merged 16 commits into from
Jan 31, 2025

Conversation

PaulJonasJost
Copy link
Collaborator

The following was fixed/changed:

  1. The left plot does not display a legend anymore, making it better visible
  2. Downloadbuttons for all preprocessing methods should work now
  3. Adapted the info text such that it fits the setup in other modules and is not greyed out

I have specifically NOT checked and/or worked on the getRCode and i dont think it should be a concern of this PR.

Things to further consider to further improve the volcano plots:

  • we could use something like a cowplot to separate the legend and show it
  • we could also have a toggleable legend (too much clutter?)
  • To speed up volcano rendering we could either downsample or bin values together.

PaulJonasJost and others added 11 commits August 8, 2024 13:23
Merge into Main
* changed to show debug text again; to let user know what is going on; addresses #421 
* Make things clearer in layout, incl. button design, placement, tip highlights and promoting more parallelism (#419, #413, #414)
* changes and clean up to the docs to easen the retrieval of information
* indicate that batch collection is optional, adding explicit help file - addresses #418 
* making top links more obvious; attention no order change #415 as suggested
* make cOmicsArt print prettier
* Crash fix sig ana (#420)
* add hiding of tabs to avoid usage of results; fixes #417
* fixed to work with native SumExp next to cOmicsArt created #404 (#425)
…hing aside from DESeq2 and DESeq2 not working on multi tabs
@PaulJonasJost PaulJonasJost requested a review from LeaSeep January 25, 2025 17:21
@PaulJonasJost PaulJonasJost self-assigned this Jan 25, 2025
@PaulJonasJost
Copy link
Collaborator Author

Leave Options for multiple plots
change to cowplot

Copy link
Collaborator

@LeaSeep LeaSeep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Major (maybe even a new issue? ):

  • The app crashes if Testdata > Deseq> Sig Ana > select 1 condition DO -> adding a new condition DO => Crash
[1] "Start the Significance Analysis"
[1] "Updating data..."
Warning: Error in session$userData[[ns(paste0(name, button))]]$destroy: attempt to apply non-function

Minor:
I think I would put the options 'adj. p value threshold', 'LogFC thresholds', 'Select the anno, 'Show legen corrected / uncorrected' to the right of the plots and decrease font size of legend

@PaulJonasJost
Copy link
Collaborator Author

Major (maybe even a new issue? ):

Will fix 👍🏼

Minor: ...

Will leave that as the functionality rn is not well designed (recomputation every time) and opened another issue regarding that.

@PaulJonasJost PaulJonasJost merged commit 7246564 into develop Jan 31, 2025
1 check passed
@PaulJonasJost PaulJonasJost deleted the Volcano_Plot branch January 31, 2025 08:45
@PaulJonasJost PaulJonasJost mentioned this pull request Feb 20, 2025
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants