Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Moved optional tests to bottom #445

Merged
merged 2 commits into from
Jan 30, 2025
Merged

Moved optional tests to bottom #445

merged 2 commits into from
Jan 30, 2025

Conversation

PaulJonasJost
Copy link
Collaborator

Separated throuhg an Optional, to make it clear, errors in here wil be automatically taken care of!

@PaulJonasJost PaulJonasJost mentioned this pull request Jan 30, 2025
Closed
@LeaSeep LeaSeep self-requested a review January 30, 2025 16:16
LeaSeep
LeaSeep approved these changes Jan 30, 2025
View reviewed changes
Copy link
Collaborator

@LeaSeep LeaSeep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would add under
`Some overall Checks have been run:'
'REQUIRED (must be all yes)'
and then to the optional
'OPTIONAL (normally should be yes)'
'NAs will results in a missing datapoint, which is potentially unexpected'
or sth similar

@PaulJonasJost PaulJonasJost merged commit 479108f into develop Jan 30, 2025
1 check passed
@PaulJonasJost PaulJonasJost deleted the ordering_of_test_message branch January 30, 2025 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LeaSeep LeaSeep LeaSeep approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@PaulJonasJost @LeaSeep