Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

R_code_revamp #448

Merged
merged 10 commits into from
Feb 3, 2025
Merged

R_code_revamp #448

merged 10 commits into from
Feb 3, 2025

Conversation

PaulJonasJost
Copy link
Collaborator

Code rework for data selection and preprocessing. Now only smaller changes should be left within the server. All relevant changes to the data are sourced out into function that can be called and later crawled for Code generation

@PaulJonasJost
removed unused file
508fe91
@PaulJonasJost
first step: made data selection a function to outsource actualy proce…
1ea35cb 
…ssing. Done for future bulletproofing of R Code Snippets
@PaulJonasJost
Tmp commit
21f28b1
@PaulJonasJost
Merge branch 'develop' into R_code_revamp
196ac31
@PaulJonasJost
Moved all relevant functionality outside of base server. Will be used…
7546b33 
… for code creation Later!

Addtionally closes #447, Closes #435
And fixes a Small bug in the report where the batch formula and regular formula of deseq processing would be swapped
@PaulJonasJost PaulJonasJost requested a review from LeaSeep January 31, 2025 13:41
@PaulJonasJost PaulJonasJost self-assigned this Jan 31, 2025
LeaSeep
LeaSeep reviewed Feb 3, 2025
View reviewed changes
Copy link
Collaborator

@LeaSeep LeaSeep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see global var - on serve not any issue if we have less than 10 - if more than they maybe see each other again - unsure

LeaSeep
LeaSeep approved these changes Feb 3, 2025
View reviewed changes
Copy link
Collaborator

@LeaSeep LeaSeep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see comments + commit

PaulJonasJost and others added 2 commits February 3, 2025 16:48
@PaulJonasJost @LeaSeep
Update program/shinyApp/R/util.R
295b1de 
Co-authored-by: Lea Seep <74967328+LeaSeep@users.noreply.github.com>
@PaulJonasJost
non global assignment
b8a97c1
@PaulJonasJost PaulJonasJost merged commit 8b1ce6c into develop Feb 3, 2025
1 check passed
@PaulJonasJost PaulJonasJost deleted the R_code_revamp branch February 4, 2025 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LeaSeep LeaSeep LeaSeep approved these changes

Assignees

@PaulJonasJost PaulJonasJost

Labels
ready for review work in progress
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@PaulJonasJost @LeaSeep