Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data clearing btn #484

Merged
merged 9 commits into from
Feb 19, 2025
Merged

Data clearing btn #484

merged 9 commits into from
Feb 19, 2025

Conversation

LeaSeep
Copy link
Collaborator

@LeaSeep LeaSeep commented Feb 18, 2025

please answer to comment in issue #478

Copy link
Collaborator

@PaulJonasJost PaulJonasJost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the reset button does not do as we want or at least not everything we want. Following example: Upload the data files -> Clear Data -> Visual inspection. The same if you replace Visual Inspection with Upload Data. This is very misleading and thus should be correctly cleared instead of just clearing the interface (which I think is what reset does).

this commit from long ago should do the trick 🙈

@LeaSeep
Copy link
Collaborator Author

LeaSeep commented Feb 18, 2025

As Im already worked on the debug messages upon celar data will also integrate on this branch fixes related to #477

Copy link
Collaborator

@PaulJonasJost PaulJonasJost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Text for upload is wonderful!

Clearing still does not work yet for some reason 🙈 If we want to do it correctly needs to be fixed, otherwise I can also see this as a mainly cosmetic ting for the user

@LeaSeep LeaSeep merged commit 42eacde into develop Feb 19, 2025
1 check passed
@LeaSeep LeaSeep deleted the data_clearing_btn branch February 19, 2025 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants