Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Additional test data #490

Merged
merged 9 commits into from
Feb 19, 2025
Merged

Additional test data #490

merged 9 commits into from
Feb 19, 2025

Conversation

LeaSeep
Copy link
Collaborator

@LeaSeep LeaSeep commented Feb 18, 2025 •
edited
Loading

To Do:

  • replace general 'gene' to entitiy
  • make defaults omic type specific
  • check on pre-processing procedures (used Lipidomics would only need log transform)
  • throughly test datasets
  • hide enrichment tabs if Lipidomics or Metabolomcs

@LeaSeep
Copy link
Collaborator Author

LeaSeep commented Feb 18, 2025

addresses #471

@LeaSeep LeaSeep marked this pull request as ready for review February 19, 2025 14:42
PaulJonasJost
PaulJonasJost approved these changes Feb 19, 2025
View reviewed changes
Copy link
Collaborator

@PaulJonasJost PaulJonasJost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, tested all plots and it worked. Gonna Merge now as my changes were mainly cosmetic!

@PaulJonasJost PaulJonasJost merged commit 2ac3c1f into develop Feb 19, 2025
1 check passed
@PaulJonasJost PaulJonasJost deleted the additionalTestData branch February 19, 2025 16:07
@PaulJonasJost PaulJonasJost mentioned this pull request Feb 20, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PaulJonasJost PaulJonasJost PaulJonasJost approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@LeaSeep @PaulJonasJost