Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notes fixed with additional option to put own notes #491

Merged
merged 3 commits into from
Feb 19, 2025

Conversation

PaulJonasJost
Copy link
Collaborator

No description provided.

Copy link
Collaborator

@LeaSeep LeaSeep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Question: How can I save the new report with additional text? If I do the strg+S it prompts me to save a mhtml which I do not want.
If saving to a html does not work would rather leave it out for now and add it as upcoming feature

@@ -170,6 +170,13 @@ enrichment_analysis_geneset_server <- function(

if(isTruthy(input$Notes) & !(isEmpty(input$Notes))){
fun_LogIt(message = "<span style='color:#298c2f;'>**Personal Notes:**</span>")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
fun_LogIt(message = "<span style='color:#298c2f;'>**Personal Notes:**</span>")
fun_LogIt(message = "<span style='color:#298c2f;'>**Personal Notes:**</span>")

Can be removed I think as not Personal Notes in small and greens shows up but the 'Notes' are massiv

)
NOTES_ADDITIONAL <<- '<textarea name="textarea" rows="5" cols="30" placeholder="Place here additional notes on the fly..."></textarea>"'
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
NOTES_ADDITIONAL <<- '<textarea name="textarea" rows="5" cols="30" placeholder="Place here additional notes on the fly..."></textarea>"'
NOTES_ADDITIONAL <<- '<textarea name="textarea" rows="5" cols="30" placeholder="Place here additional notes on the fly..."></textarea>'

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also I think we can expand on the cols initially - windo is quite narrow

@PaulJonasJost PaulJonasJost merged commit 6467c21 into develop Feb 19, 2025
1 check passed
@PaulJonasJost PaulJonasJost deleted the fixing_notes_in_report branch February 19, 2025 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants