Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Loadings plots #500

Merged
merged 4 commits into from
Feb 20, 2025
Merged

Fix Loadings plots #500

merged 4 commits into from
Feb 20, 2025

Conversation

PaulJonasJost
Copy link
Collaborator

The problem came from the (superfluous?) group argument in ggplot, and since we pass data without having it

@PaulJonasJost PaulJonasJost self-assigned this Feb 19, 2025
@PaulJonasJost
Copy link
Collaborator Author

closes #492

@PaulJonasJost
Copy link
Collaborator Author

now also closes #489

LeaSeep
LeaSeep requested changes Feb 20, 2025
View reviewed changes
Copy link
Collaborator

@LeaSeep LeaSeep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • complete crash if Transcriptomics Testdata -> pre-processing DESeq -> PCA - >plot PCA -> select for cell two options glick get new pca -> crash
[1] "Calculate PCA"
Warning: Error in observe: object 'pca' not found
  1: runApp

@PaulJonasJost
Copy link
Collaborator Author

after new changes and discussing, ready for merge

@PaulJonasJost PaulJonasJost merged commit 0a68259 into develop Feb 20, 2025
1 check passed
@PaulJonasJost PaulJonasJost deleted the fix_loadings_plot branch February 20, 2025 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LeaSeep LeaSeep LeaSeep requested changes

Assignees

@PaulJonasJost PaulJonasJost

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@PaulJonasJost @LeaSeep