Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor the indy_config.py configuration. #40

Merged
merged 2 commits into from
Aug 31, 2022
Merged

Refactor the indy_config.py configuration. #40

merged 2 commits into from
Aug 31, 2022

Conversation

WadeBarnes
Copy link
Contributor

  • Replace the template approach with a sed command that only updates the NETWORK_NAME variable.
  • This insures the indy-node package install is in complete control of the file and only the required variable, NETWORK_NAME, is updated as needed.

Signed-off-by: Wade Barnes wade@neoterictech.ca

@WadeBarnes
Refactor the indy_config.py configuration.
d77fc0d 
- Replace the template approach with a sed command that only updates the NETWORK_NAME variable.
- This insures the indy-node package install is in complete control of the file and only the required variable, NETWORK_NAME, is updated as needed.

Signed-off-by: Wade Barnes <wade@neoterictech.ca>
@WadeBarnes
Copy link
Contributor Author

I ran into additional issues with the template approach to the configuration so I refactored it to use sed replacement to update the network name.

@SylvainMartel SylvainMartel merged commit 61ab365 into ICCS-ISAC:main Aug 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SylvainMartel SylvainMartel SylvainMartel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@WadeBarnes @SylvainMartel