Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: NER-only NLP pipeline #1538

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

chore: NER-only NLP pipeline #1538

wants to merge 1 commit into from

Conversation

ClemDoum
Copy link
Contributor

@ClemDoum ClemDoum commented Sep 4, 2024

PR description

Remove unused NLP API and keep the only used NLP stage (NER).
The other stages are irrelevant for Datashare (and probably in general).

This change is made in the context of #1452 and is a prerequisite for #1541 (which implements batch processing).

Changes

datashare-api ⚠️

Removed

  • NlpStage since Datashare only uses the NER stage

Changed

  • adapted the Pipeline APIs to NlpStage removal

datashare-core-nlp

Changed

  • udpdated the CoreNlpPipelineModels to the new Pipeline API

Remove

  • CoreNlpNerModels, CoreNlpPosModels

datashare-app

  • udpdated the EmailPipeline to the new Pipeline API

@ClemDoum ClemDoum marked this pull request as ready for review September 5, 2024 10:27
@ClemDoum ClemDoum mentioned this pull request Sep 5, 2024
1 task
@ClemDoum ClemDoum self-assigned this Sep 9, 2024
@ClemDoum ClemDoum requested a review from a team September 9, 2024 07:42
Copy link
Contributor

@caro3801 caro3801 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants