Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add deprecated synonyms to removed params #703

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Add deprecated synonyms to removed params #703

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 9 additions & 5 deletions parsec/parsec.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -378,7 +378,7 @@ static void parsec_vp_init( parsec_vp_t *vp,

parsec_context_t* parsec_init( int nb_cores, int* pargc, char** pargv[] )
{
int ret, nb_vp, p, t, nb_total_comp_threads, display_vpmap = 0;
int ret, idx, nb_vp, p, t, nb_total_comp_threads, display_vpmap = 0;
int comm_binding_parameter = -1;
char *binding_parameter = NULL;
__parsec_temporary_thread_initialization_t *startup;
Expand Down Expand Up @@ -521,14 +521,17 @@ parsec_context_t* parsec_init( int nb_cores, int* pargc, char** pargv[] )
false, false, vpmap_parameter, &vpmap_parameter);

/* thread binding */
parsec_mca_param_reg_int_name("bind", "main_thread", "Force the binding of the thread calling parsec_init",
idx = parsec_mca_param_reg_int_name("bind", "main_thread", "Force the binding of the thread calling parsec_init",
false, false, parsec_runtime_bind_main_thread, &parsec_runtime_bind_main_thread);
parsec_mca_param_reg_int_name("bind", "threads", "Bind main and worker threads", false, false,
parsec_mca_param_reg_syn_name(idx, "runtime", "bind_main_thread", true);
idx = parsec_mca_param_reg_int_name("bind", "threads", "Bind main and worker threads", false, false,
parsec_runtime_bind_threads, &parsec_runtime_bind_threads);
parsec_mca_param_reg_int_name("bind", "comm", "Bind the communication thread to physical core <int>."
parsec_mca_param_reg_syn_name(idx, "parsec", "bind", true);
idx = parsec_mca_param_reg_int_name("bind", "comm", "Bind the communication thread to physical core <int>."
"-1: do not bind."
"Warning: binding relies on HWLOC, be careful when using with cgroups",
false, false, comm_binding_parameter, &comm_binding_parameter);
parsec_mca_param_reg_syn_name(idx, "parsec", "bind_comm", true);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we have parsec_bin_main_thread and parsec_bin_comm ? Make it parsec_bind_comm_thread to be similar.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I updated the description to explain: the synonyms are reintroduced for the only purpose of complaining if they are used, and they are expected to be inconsistent (reason they got removed in the first place)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since I get you, the synonym registration with deprecated=true does not cause a warning to be issued when the mca is used, but only when calling mca_show_params does a warning get issued. Am I using this wrong?

parsec_mca_param_reg_string_name("bind", "map", "Provide a map description of the binding.",
false, false, binding_parameter, &binding_parameter);

Expand Down Expand Up @@ -587,8 +590,9 @@ parsec_context_t* parsec_init( int nb_cores, int* pargc, char** pargv[] )

#if defined(PARSEC_PROF_GRAPHER)
char *dot_param = NULL;
parsec_mca_param_reg_string_name("profile", "dot", "Prefix for the DOT file name containing the DAGs executed by parsec (one file per rank)",
idx = parsec_mca_param_reg_string_name("profile", "dot", "Prefix for the DOT file name containing the DAGs executed by parsec (one file per rank)",
false, false, dot_param, &dot_param);
parsec_mca_param_reg_syn_name(idx, "parsec", "dot", true);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

parsec_profile_dot ?

if( NULL != dot_param ) {
asprintf(&parsec_dot_file, "%s-%d.dot", dot_param, parsec_debug_rank);
}
Expand Down
Loading