EAGLE-1331: Fix bug where QuickActions with no keyboard shortcut would still display "[]"

[james-strauss-uwa]

Removed 'empty' keys from QuickAction helper functions.
Updated KeyboardShortcut.getText() to return empty string if no shortcut.

Summary by Sourcery

Improve the KeyboardShortcut class by removing unnecessary 'empty' keys from QuickAction helper functions and updating getText() to return an empty string when no shortcuts are defined.

Bug Fixes:

• Fix KeyboardShortcut.getText() to return an empty string instead of '[]' when no key texts are produced.

Enhancements:

• Remove 'empty' keys from QuickAction helper functions to streamline the creation of keyboard shortcuts.

[sourcery-ai]

Reviewer's Guide by Sourcery

This PR modifies the KeyboardShortcut class to improve how empty shortcuts are handled. The changes include updating the getText() method to return an empty string instead of "[]" when there are no shortcuts, and modifying QuickAction helper functions to use an empty array instead of an array with an empty key.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change	Details	Files
Modified getText() method to handle empty shortcuts more gracefully	Added a check for empty texts array Returns empty string instead of "[]" when no shortcuts exist	src/KeyboardShortcut.ts
Updated QuickAction helper functions to use empty key arrays	Replaced [new Key("")] with [] in QUICK_ACTION function Replaced [new Key("")] with [] in QUICK_ACTION_DOCS function	src/KeyboardShortcut.ts

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time. You can also use
  this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey @james-strauss-uwa - I've reviewed your changes and they look great!

Here's what I looked at during the review

• 🟢 General issues: all looks good
• 🟢 Security: all looks good
• 🟢 Testing: all looks good
• 🟢 Complexity: all looks good
• 🟢 Documentation: all looks good

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

[M-Wicenec]

nice catch