Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eagle 1314 #784

Merged
merged 2 commits into from
Nov 25, 2024
Merged

Eagle 1314 #784

merged 2 commits into from
Nov 25, 2024

Conversation

M-Wicenec
Copy link
Collaborator

@M-Wicenec M-Wicenec commented Nov 25, 2024

Summary by Sourcery

Enhance the visual styling of the issues display and accordion components in the CSS files, and fix a typo in an error message in the Edge.ts file.

Bug Fixes:

  • Correct typo in error message within Edge.ts for clarity.

Enhancements:

  • Improve CSS styling for issues display by removing padding and adjusting border properties for a cleaner look.
  • Refine accordion button styling in base.css by adding padding and setting border radius to zero for consistency.

Copy link
Contributor

sourcery-ai bot commented Nov 25, 2024

Reviewer's Guide by Sourcery

This PR makes UI improvements to the issues display component and updates an error message. The changes primarily focus on styling adjustments for the issues display accordion and its elements, removing padding, adding borders, and adjusting colors. There's also a minor text change to an error message in the Edge validation logic.

Class diagram for Edge class error message update

classDiagram
    class Edge {
        - showFixErrorMessage: "An edge between two siblings should not be loop aware"
        + showFixErrorMessage: "Edge between two siblings should not be loop aware"
    }
    note for Edge "Updated error message text in Edge class validation logic"
Loading

File-Level Changes

Change Details Files
Updated styling for the issues display accordion and its components
  • Removed 10px padding from table body and issues body
  • Added styling for errors accordion item with no border and 0px border radius
  • Set padding to 0px for errors and warnings accordion bodies
  • Added left border styling for error and warning list items with different colors
  • Updated accordion button styling with specific padding and border radius
  • Removed margin-bottom from accordion items and updated border properties
static/tables.css
static/base.css
Modified error message text for edge validation
  • Changed error message from 'An edge between two siblings should not be loop aware' to 'Edge between two siblings should not be loop aware'
src/Edge.ts

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@M-Wicenec M-Wicenec merged commit 5e8b0cb into master Nov 25, 2024
1 check passed
@M-Wicenec M-Wicenec deleted the eagle-1314 branch November 25, 2024 06:35
Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @M-Wicenec - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟡 General issues: 1 issue found
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@@ -284,6 +283,11 @@ td:first-child input {
overflow-y: auto;
}

.issuesDisplay #issuesDisplayErrorsAccordionItem{
border-radius: 0px !important;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestion: Consider avoiding !important flags in CSS rules

Using !important makes styles harder to maintain and override. Consider restructuring the CSS specificity to achieve the same effect without !important.

Suggested change
border-radius: 0px !important;
border-radius: 0;

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant