Eagle 1375 #805
Merged
Eagle 1375 #805
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…per at the top of the page
Reviewer's Guide by SourceryThis PR implements UI changes to display active graph configuration information in two locations: the graph name wrapper at the top of the page and in the graph inspector panel. The changes include adding new UI elements, styling updates, and the necessary supporting TypeScript code. Updated Class Diagram for Eagle and FileInfoclassDiagram
class Eagle {
+ko.PureComputed activeConfigText
+toggleWindows() : void
}
class FileInfo {
+getText() : string
}
note for Eagle "Added activeConfigText to display active graph configuration."
note for FileInfo "Updated getText method to include strong HTML tags."
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey @M-Wicenec - I've reviewed your changes and found some issues that need to be addressed.
Blocking issues:
- Consider using a safe HTML encoding method for repository information (link)
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🔴 Security: 1 blocking issue
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
| @@ -371,9 +371,9 @@ export class FileInfo { | |||
| getText = () : string => { | |||
| if (this.repositoryName !== ""){ | |||
| if (this.path === ""){ | |||
| return this.repositoryService + ": " + this.repositoryName + " (" + this.repositoryBranch + "): " + this.name; | |||
| return "<strong>" + this.repositoryService + "</strong>: " + this.repositoryName + " (" + this.repositoryBranch + "): " + this.name; | |||
There was a problem hiding this comment.
🚨 issue (security): Consider using a safe HTML encoding method for repository information
Direct string concatenation with HTML tags could lead to XSS vulnerabilities if any of the fields contain special characters. Consider using a sanitization function or template system.
james-strauss-uwa
approved these changes
Dec 12, 2024
src/Eagle.ts
Outdated
| @@ -385,6 +385,14 @@ export class Eagle { | |||
| return fileInfo.getText(); | |||
| }, this); | |||
|
|
|||
| activeConfigText : ko.PureComputed<string> = ko.pureComputed(() => { | |||
There was a problem hiding this comment.
Can we name this 'activeConfigHtml' to indicate that it returns html
src/FileInfo.ts
Outdated
| @@ -371,9 +371,9 @@ export class FileInfo { | |||
| getText = () : string => { | |||
There was a problem hiding this comment.
Maybe rename to getHtml() here too
templates/inspector.html
Outdated
| </div> | ||
| <div class="row inspectorEdgeSrcNodeId contentObject"> | ||
| <div class="col-6 col contentObjectTitle"> | ||
| <h5>Config Length: </h5> |
There was a problem hiding this comment.
Maybe "Config Fields:" instead of length?
There was a problem hiding this comment.
yea maybe, i wasnt quite sure what to call it without making it too long
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
displaying active graph config in the graph name wrapper and in the graph inspector
Summary by Sourcery
Display the active graph configuration details in the graph inspector and graph name wrapper, enhancing the user interface with better organization and additional functionality.
New Features:
Enhancements: