Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use release version of Fomantic UI CSS when available #3575

Closed
fniessink opened this issue Mar 23, 2022 · 1 comment · Fixed by #4755
Closed

Use release version of Fomantic UI CSS when available #3575

fniessink opened this issue Mar 23, 2022 · 1 comment · Fixed by #4755
Assignees
@fniessink
Labels
Tech Technical change without significant user impact

Comments

@fniessink
Copy link
Member

fniessink commented Mar 23, 2022 •
edited
Loading

The current version of Fomantic UI CSS (2.8.8) has an extra semicolon which makes it incompatible with Webpack 5, which in turn prevents an upgrade to Create React App v5.0.

We use https://github.com/peacekeeper/Fomantic-UI-CSS.git#c94ff9bd5ab897cd3e3facd2c968090da8755dcb which contains a fixed version of Fomantic UI CSS.

When Fomantic UI CSS >2.8.8 has been released, we can change the dependency to use the released version of Formantic UI CSS at https://github.com/fomantic/Fomantic-UI-CSS
@fniessink fniessink added the Tech Technical change without significant user impact label Mar 23, 2022
@lubber-de
Copy link

Fomantic-UI 2.9.0 was just released

@fniessink fniessink self-assigned this Oct 21, 2022
fniessink added a commit that referenced this issue Oct 21, 2022
@fniessink
Upgrade to Fomantic-UI-CSS 2.9.0. Closes #3575.
b214c71
@fniessink fniessink mentioned this issue Oct 21, 2022
Merged
@fniessink fniessink linked a pull request Oct 21, 2022 that will close this issue
Upgrade to Fomantic-UI-CSS 2.9.0 #4755
Merged
fniessink added a commit that referenced this issue Oct 21, 2022
@fniessink
Upgrade to Fomantic-UI-CSS 2.9.0. Closes #3575.
848d8c1
@fniessink fniessink moved this to Released in Quality-time backlog May 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fniessink fniessink

Labels
Tech Technical change without significant user impact
Projects
Quality-time backlog
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Upgrade to Fomantic-UI-CSS 2.9.0 ICTU/quality-time
2 participants
@fniessink @lubber-de