Testing whether a word is plural or not #31
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #28, this PR adds three new functions to the inflector class:
is_plural
- whether a word is plural or uncountableis_singular
- whether a word is singular or uncountableis_uncountable
- whether a word is uncountableI have deliberately not added helper functions at this point as this functionality is fairly niche.
Points raised in issue
This was not possible because of the catchall regex like
/$/
.Known bugs
This PR does break the testing because, I believe, the inflections in some languages are incomplete, e.g.:
singularize('interés') = 'interé'
which is incorrectpluralize('kirazlar') = 'kirazlarlar'
which is incorrectUnfortunately, I am not a speaker of these languages and therefore cannot correct them confidently, however some imcomplete suggestions: