Skip to content
This repository has been archived by the owner on Apr 6, 2023. It is now read-only.

Fix remaining uses of legacy default-kwarg ProcessBlock API after IDAES/idaes-pse#959 #139

Merged
merged 2 commits into from
Sep 16, 2022
Merged

Fix remaining uses of legacy default-kwarg ProcessBlock API after IDAES/idaes-pse#959 #139

merged 2 commits into from
Sep 16, 2022

Conversation

lbianchi-lbl
Copy link
Contributor

Resolves (partially) IDAES/examples#9

Proposed changes:

Legal Acknowledgement

By contributing to this software project, I agree to the following terms and conditions for my contribution:

  1. I agree my contributions are submitted under the license terms described in the LICENSE.txt file at the top level of this directory.
  2. I represent I am authorized to make the contributions and grant the license. If my employer has rights to intellectual property that includes these contributions, I represent that I have received permission to make contributions and grant the required license on behalf of that employer.

@lbianchi-lbl lbianchi-lbl changed the title Fix remaining uses of legacy default-kwarg ProcessBlock API after IDAES/idas-pse#959 Fix remaining uses of legacy default-kwarg ProcessBlock API after IDAES/idaes-pse#959 Sep 15, 2022
andrewlee94
andrewlee94 approved these changes Sep 16, 2022
View reviewed changes
Copy link
Member

@andrewlee94 andrewlee94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like there were more lingering uses of default that we hadn't caught than I expected.

@andrewlee94 andrewlee94 merged commit 6b8d461 into IDAES:main Sep 16, 2022
@ksbeattie ksbeattie added the Priority:High High Priority Issue or PR label Sep 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@andrewlee94 andrewlee94 andrewlee94 approved these changes

@eslickj eslickj eslickj approved these changes

Assignees

@lbianchi-lbl lbianchi-lbl

Labels
Priority:High High Priority Issue or PR
Projects
No open projects
2023 February Release
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lbianchi-lbl @eslickj @andrewlee94 @ksbeattie