-
Notifications
You must be signed in to change notification settings - Fork 249
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update docs to use IDAES/examples instead of IDAES/examples-pse #1132
Conversation
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #1132 +/- ##
==========================================
- Coverage 76.35% 76.35% -0.01%
==========================================
Files 369 369
Lines 60715 60715
Branches 11198 11198
==========================================
- Hits 46359 46356 -3
- Misses 11954 11958 +4
+ Partials 2402 2401 -1 ☔ View full report in Codecov by Sentry. |
Nitpick: I kinda liked the diataxis table with the somewhat smaller fonts... |
@dangunter It looks like the docs build for this PR has expired; could you fix the conflict so that the docs can be rebuilt. Note that our supported Python versions are now 3.8-3.11. |
@andrewlee94 @MAZamarripa and @lbianchi-lbl this is ready for review now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only one minor comment on updating the supported Python versions, but otherwise looks good to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Fixes #1131
Summary/Motivation:
Documentation needs to point to the new examples
Changes proposed in this PR:
Legal Acknowledgement
By contributing to this software project, I agree to the following terms and conditions for my contribution: