-
Notifications
You must be signed in to change notification settings - Fork 235
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Option to skip parallel component checks #1417
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1417 +/- ##
==========================================
- Coverage 77.89% 77.89% -0.01%
==========================================
Files 394 394
Lines 65079 65080 +1
Branches 14389 14390 +1
==========================================
- Hits 50695 50692 -3
- Misses 11795 11799 +4
Partials 2589 2589 ☔ View full report in Codecov by Sentry. |
Why add this feature instead of relaxing the tests for these older models? I suppose the reason is that we still want to test that these have no extreme Jacobian entries, and condition numbers in some range. Is there no way to extract just the numerical warnings that we actually want to enforce (as we might do with |
@Robbybp Mostly as a placeholder until we get the new scaling tools in place and have the time to go and address each of these. We also have a case where someone is working on updating some of the power plant examples for us, and I asked them to add checks for structural and numerical issues, but they lack the time or background to try to fix these for now. Thus, I added this so they can skip these tests for now and get their PR merged without waiting until the power plant team can address the issues. |
Fixes None
Summary/Motivation:
This adds an option to skip checks for parallel constraints and variables, primarily for use in testing where we have cases of known near-parallel components. This is mostly for backward compatibility with older models which we do not currently have time to fix.
Changes proposed in this PR:
Legal Acknowledgement
By contributing to this software project, I agree to the following terms and conditions for my contribution: