Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin typos version to latest currently available tag v1.24.5 #1486

Merged
merged 3 commits into from
Sep 5, 2024

Conversation

lbianchi-lbl
Copy link
Contributor

Resolves #1485

Legal Acknowledgement

By contributing to this software project, I agree to the following terms and conditions for my contribution:

  1. I agree my contributions are submitted under the license terms described in the LICENSE.txt file at the top level of this directory.
  2. I represent I am authorized to make the contributions and grant the license. If my employer has rights to intellectual property that includes these contributions, I represent that I have received permission to make contributions and grant the required license on behalf of that employer.

@lbianchi-lbl lbianchi-lbl added the Priority:High High Priority Issue or PR label Sep 5, 2024
@lbianchi-lbl lbianchi-lbl marked this pull request as ready for review September 5, 2024 18:36
@lbianchi-lbl
Copy link
Contributor Author

@bpaul4 I've added you and myself as code owners for the typos config file, so that we're added as reviewers whenever it's modified.

Copy link
Contributor

@bpaul4 bpaul4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, thank you @lbianchi-lbl for opening the PR. Noting that we will probably reverse the "workpace" exception once #1484 is merged, or as part of it if this PR is merged first.

@lbianchi-lbl
Copy link
Contributor Author

This is great, thank you @lbianchi-lbl for opening the PR. Noting that we will probably reverse the "workpace" exception once #1484 is merged.

Yeah, I was planning on removing the DMF exceptions directly within #1484 as a further double-check that all affected files have been removed.

@lbianchi-lbl lbianchi-lbl merged commit 8140a3d into IDAES:main Sep 5, 2024
22 checks passed
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.36%. Comparing base (fe422c0) to head (645e249).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1486      +/-   ##
==========================================
- Coverage   76.37%   76.36%   -0.01%     
==========================================
  Files         393      393              
  Lines       65086    65086              
  Branches    14426    14426              
==========================================
- Hits        49708    49705       -3     
- Misses      12816    12820       +4     
+ Partials     2562     2561       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority:High High Priority Issue or PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pin version used for CI spellchecking to avoid surprise failures after updates
3 participants