-
Notifications
You must be signed in to change notification settings - Fork 238
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Option: Warnings and/or Deprecation Warnings Raise RuntimeError #822
Conversation
Codecov Report
@@ Coverage Diff @@
## main #822 +/- ##
=======================================
Coverage 67.92% 67.92%
=======================================
Files 567 567
Lines 62208 62228 +20
Branches 11513 11520 +7
=======================================
+ Hits 42254 42268 +14
- Misses 17780 17784 +4
- Partials 2174 2176 +2
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, but I had one question about what appears to be an unnecessary duplicated line.
Changes proposed in this PR:
This adds to config options,
warning_to_exception
anddeprecation_to_exception
. If these options are set to True, they make log messages at warning or above raise and exception and/or warning and above log messages that say deprecat* raise an exception. This can be used to test that a model raises no warnings or uses no deprecated methods or models. For warnings it also lets you see a traceback, so you can get more specific diagnostic info on the warning.Legal Acknowledgement
By contributing to this software project, I agree to the following terms and conditions for my contribution: