Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Label Outlier Check Box and Minor Design changes on Boxplot Dialog. #8271

Open
wants to merge 12 commits into
base: master
Choose a base branch
from

Conversation

MeSophie
Copy link
Contributor

Fixes partially #8242.
@rdstern I fixes part a) and b).

@lloyddewit @WezzieBanda please can you have a look?

Copy link
Collaborator

@rdstern rdstern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MeSophie good to get started.
a) But sorry I misled you - it is not the Plot Options to move to the right, instead it is the Horizontal Plot option.

b) And I notice you already added the Geom_text option into that pull-down. That's great, but could you just call it Text Options.

c) And move the Tufte Option up one control. Later I am sure you will have more controls to add to the new row with the Label options.

And hopefully get help from Wezzie on the code and options to use for the labels

@WezzieBanda
Copy link

@MeSophie The dialogue seems not to be working for me, I believe it has to do with how the sta_summary_fun was incorporated in the code.
Boxplot label

@MeSophie
Copy link
Contributor Author

@WezzieBanda Thank you For this. I already fixed it. So can you pull the changes and text again?

@rdstern Please this Text Options will be linked with Geom text function or Label Outlier? Also I didn't move the Tufte Option up because of Jitter and Tranparency Input

image

@WezzieBanda
Copy link

@MeSophie looks good.

Copy link
Contributor

@lloyddewit lloyddewit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MeSophie Looks good to me, just one small question

instat/dlgBoxPlot.vb Outdated Show resolved Hide resolved
Copy link
Collaborator

@rdstern rdstern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@WezzieBanda and @MeSophie this is looking very promising. It seems to work! Well done.

But there are a couple of challenges still:

a) When I change the coefficient from 1.5 the boxplot changes, but the labelled outliers are still for the default value of 1.5. Can the code for the outliers reflect the coefficient used?

image

b) I also tried an example where there are no outliers and it then gives an error. An example is our usual survey data with yield against Variety. (It works fine with yield against Village, where there is just one outlier.)
c) And a - i hope trivial design change. Could you swap the Add Points and the Label outliers on the Left of the dialogue. Then you could move the Tufte option up one place on the right. (It looks lonely down there now!) And could you change Tufte Boxplots to Tufte Boxplot (so singular), to be consistent with the option at the top.
d) And another one. The label outliers is only for the Boxplot option. It does not apply to the jitter or the violin plots.

@MeSophie
Copy link
Contributor Author

MeSophie commented May 5, 2023

@rdstern I'm done with the parts a), c) and d). I added one control for Size for part a) for now is the only way that I see to play with the size of outlier label. I'm still investigate of part b).

@rdstern
Copy link
Collaborator

rdstern commented May 6, 2023

@MeSophie this is promising. I think you can make some further progress, but then, for efficiency you might then wait for some help on the R-code from @lilyclements. This may not be till the week of 12 June, when she will be visiting Kenya (though you are still likely to be working from home then.).
a) The outliers are still given for the coefficient of 1.5, even when you change the coeff.
b) As mentioned above, there is an error if there are no outliers (saurvey data with yield v variety is an example.
c) I am afraid a new one - the outlier is only the y variable. The code gives examples where you may wish to label another variable, e.g. the date. This will change the dialogue a bit to add space.
d) When it is working it would be good to add the same to the Climatic > Check Datat Boxplot dialogue - so consider this as the coding is done, i.e. that you will be using it in 2 dialogues.

On the boxplot design - point c, you may wish to move the Horizontal Plot control back to the Left. Then you can move Tufte up and add a checkbox with label Variable: (default unchecked. If checked, then it opens a single receiver that can take a variable to be plotted.

@N-thony
Copy link
Collaborator

N-thony commented Jul 6, 2023

@MeSophie this is promising. I think you can make some further progress, but then, for efficiency you might then wait for some help on the R-code from @lilyclements. This may not be till the week of 12 June, when she will be visiting Kenya (though you are still likely to be working from home then.). a) The outliers are still given for the coefficient of 1.5, even when you change the coeff. b) As mentioned above, there is an error if there are no outliers (saurvey data with yield v variety is an example. c) I am afraid a new one - the outlier is only the y variable. The code gives examples where you may wish to label another variable, e.g. the date. This will change the dialogue a bit to add space. d) When it is working it would be good to add the same to the Climatic > Check Datat Boxplot dialogue - so consider this as the coding is done, i.e. that you will be using it in 2 dialogues.

On the boxplot design - point c, you may wish to move the Horizontal Plot control back to the Left. Then you can move Tufte up and add a checkbox with label Variable: (default unchecked. If checked, then it opens a single receiver that can take a variable to be plotted.

@MeSophie any progress? Also, this PR has conflicts, can resolve them?

@N-thony
Copy link
Collaborator

N-thony commented Jul 26, 2023

@MeSophie this PR has conflicts, can you resolve them?

@N-thony
Copy link
Collaborator

N-thony commented Nov 13, 2023

@MeSophie this PR has conflicts, can you resolve them?

@MeSophie any update here?

@N-thony
Copy link
Collaborator

N-thony commented Dec 18, 2023

@MeSophie this PR has conflicts, can you resolve them?

@MeSophie any update here?

@MeSophie we are about to go for christmas and new year holiday, can you update on this? Do you think it will be done in one week?

Copy link
Collaborator

@rdstern rdstern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MeSophie this is not urgent compared to your other work. But it would be nice if easy, given you have started.
a) When I change the coefficient for the boxplot, this is ignored and I still get the default labels from coeff 1.5.
b) I get an error if there are no outleirs. For example survey yield against variety. Against village it works fine, as there is one outlier.

@MeSophie
Copy link
Contributor Author

MeSophie commented Jan 9, 2024

@MeSophie this is not urgent compared to your other work. But it would be nice if easy, given you have started. a) When I change the coefficient for the boxplot, this is ignored and I still get the default labels from coeff 1.5. b) I get an error if there are no outleirs. For example survey yield against variety. Against village it works fine, as there is one outlier.

@rdstern I'm on it for part b) if we remove the outlier.colour="red" parameter as a defaut value of boxplot function ( (ggplot2::geom_boxplot(outlier.colour="red"))) so that the user can take this parameter from sub dialog it will solve the bug.
For part a) i'm still investigating on it if @lilyclements can help here it will be great.

@MeSophie
Copy link
Contributor Author

@rdstern I have fixed part b). For part a) I definitively need some help from @lilyclements because in R I have tried to edit the coef in referents codes giving on adding label. But I still having the same problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants