adding help id's-1 #8809
Merged
adding help id's-1 #8809
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
N-thony
approved these changes
Feb 15, 2024
rdstern
approved these changes
Feb 15, 2024
There was a problem hiding this comment.
@N-thony I am approving as you found nothing wrong with the code.
I was still unable to test, because I (and I think @Fidel365 ) get an error when trying. There are 2 possibilies I see. The first is that this is fixing the extra keyboards in the calculator, which didn't exist earlier (in the help file). The ordinary help key is clever here and goes to the right keyboard help. Maybe there is a problem here.
The other point is that this help also goes to new dialogs that were not present earlier.
I am approving and will test as soon as it is merged. That means (I hope) that you could easily revert, if there is an unforseen problem.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue #8779 , @rdstern , the help file you sent may be the reason we are having conflicts, so I was able to test all except one because I do not have the recent help file log(i will add it once I'm done with these issues). So all work except for part (b), the id takes us to the wrong place and and part (a) I added it but i was not able to test it from my side is ready for review.