Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added the Three Variable option to the 2/3 Variable Graph #8915

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

derekagorhom
Copy link
Contributor

@derekagorhom derekagorhom commented Apr 3, 2024

Fixes partly #7260
This is ready for review
I have done A-F, currently working on G-I
For the name changes, they need to be done on the database before the title of the dialogue and the by option can be changed.

@derekagorhom derekagorhom marked this pull request as ready for review April 23, 2024 13:57
@derekagorhom
Copy link
Contributor Author

I have done items G- I
for the item where we implement the facet when the multi selector is single, apparently for the dialogue to produce results for the first value it must remain in the multi selector, so what i did was add a condition that if the values in the multi selector is more that one, the facet option will be disabled. i will have a meeting with antoine during tomorrows general meeting to see a way around this problem.
@rdstern this is ready for review

Copy link
Collaborator

@rdstern rdstern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@derekagorhom that's an excellent start. Two minor points:
a) In the labelling it says the first variable is categoric, while the others are categorical. We should be consistent. Let's have them all categoric (partenr to numeric). That's for both 2 way and 3 way.
b) You have followed my suggestion to have the facet control only available if there is just one variable in the multiple receiver. Could you change that please. There can be two facet variables, so if there are multiple variable in the recieve, then this is the first facet, and the facet variable becomes the second. (It would then ignore thewrap/rpw/column setting)
c) Could you check what happens in the 3-variable case. I think there are problems there?
And @jkmusyoka could you please do a take over of the testing and further suggestions for this dialog? It is an important one that is also in the Climatic > Describe menu.

It is the partner to the Summarise dialog (that's also in the climatic as well as the describe menus) Once @fran2or is able to test dialogs, he may take this over and you could then take on the testing of summarise, which is being improved by Vitalis.

They are important dialogs and in the (now) short list that need to be working in our improved R-Instat. And they need to be consistent with each other - eventually!

@rdstern
Copy link
Collaborator

rdstern commented May 6, 2024

@jkmusyoka you have been quiet on whether you agree on this. I hope these messages are getting through?

@derekagorhom
Copy link
Contributor Author

@rdstern , @fran2or , Below are the combinations for the 3 variable graphs.
can i know which graphs should be available for which combinations.
Thanks
Categorical by Categorical by Categorical
Categorical by Categorical by Numeric
Categorical by Numeric by Categorical
Categorical by Numeric by Numeric
Numeric by Categorical by Categorical
Numeric by Numeric by Categorical
Numeric by Categorical by Numeric
Numeric by Numeric by Numeric

@fran2or
Copy link

fran2or commented May 8, 2024

@derekagorhom Below are my initial thoughts on your query and hence there should be discussion before they are included in the code. What are your thoughts @rdstern, @jkmusyoka, @lilyclements and anyone else that can contribute?

  1. Categorical by Categorical by Categorical:

  2. Categorical by Categorical by Numeric:

  3. Categorical by Numeric by Categorical:
    -- Possible Graphs (https://ademos.people.uic.edu/Chapter11.html)

  4. Categorical by Numeric by Numeric:

  5. Numeric by Categorical by Categorical:

  6. Numeric by Numeric by Categorical:

  1. Numeric by Categorical by Numeric:
    -- Possible Graphs: Scatter Plot, Line Plot, Heatmap

  2. Numeric by Numeric by Numeric:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants