-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added the Three Variable option to the 2/3 Variable Graph #8915
base: master
Are you sure you want to change the base?
Added the Three Variable option to the 2/3 Variable Graph #8915
Conversation
I have done items G- I |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@derekagorhom that's an excellent start. Two minor points:
a) In the labelling it says the first variable is categoric, while the others are categorical. We should be consistent. Let's have them all categoric (partenr to numeric). That's for both 2 way and 3 way.
b) You have followed my suggestion to have the facet control only available if there is just one variable in the multiple receiver. Could you change that please. There can be two facet variables, so if there are multiple variable in the recieve, then this is the first facet, and the facet variable becomes the second. (It would then ignore thewrap/rpw/column setting)
c) Could you check what happens in the 3-variable case. I think there are problems there?
And @jkmusyoka could you please do a take over of the testing and further suggestions for this dialog? It is an important one that is also in the Climatic > Describe menu.
It is the partner to the Summarise dialog (that's also in the climatic as well as the describe menus) Once @fran2or is able to test dialogs, he may take this over and you could then take on the testing of summarise, which is being improved by Vitalis.
They are important dialogs and in the (now) short list that need to be working in our improved R-Instat. And they need to be consistent with each other - eventually!
@jkmusyoka you have been quiet on whether you agree on this. I hope these messages are getting through? |
@rdstern , @fran2or , Below are the combinations for the 3 variable graphs. |
Fixes partly #7260
This is ready for review
I have done A-F, currently working on G-I
For the name changes, they need to be done on the database before the
title
of the dialogue and theby
option can be changed.