Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GitHub action for releasing #14

Closed
wants to merge 7 commits into from

Conversation

sbesson
Copy link
Member

@sbesson sbesson commented Sep 28, 2020

Create minimal templates ZIP archive containing the txt files for submitters only as per #13 (comment)

The outcome of this GitHub action can be reviewed https://github.com/sbesson/idr0000-lastname-example/releases/tag/v1.0.0

Two open questions:

/cc @pwalczysko @francesw

Create minimal templates ZIP archive containing the txt files for submitters
only
Copy link
Contributor

@manics manics left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think either a calendar based tag or just a major version only (e.g. v1) makes more sense than semantic versioning.

Are you planning to provide submitters with a direct URL to the zip (fine as is), or to the release page (would be nice to add some body text to actions/create-release)?

@sbesson
Copy link
Member Author

sbesson commented Sep 30, 2020

I was looking into ways to link to a latest release asset but it looks the only options is to link to the latest release.
That probably means we need to go the second option i.e. pointing to https://github.com/IDR/idr0000-lastname-example/releases/latest/ canonically and having a nice body of text explaining about the templates.

Maybe https://github.com/IDR/idr0000-lastname-example/blob/master/README.txt should become this body of text? I defer to @francesw for what is the most suitable for submitters.

@sbesson
Copy link
Member Author

sbesson commented Oct 12, 2020

Following this morning discussion, pushed a few commits to create two sets of templates: one for HCS submission and one for non-HCS - see zip files at https://github.com/sbesson/idr0000-lastname-example/releases/tag/v1.0.5 @francesw.

Copy link
Member

@francesw francesw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

HCS and experiment template zips look fine.

@sbesson
Copy link
Member Author

sbesson commented Jan 14, 2021

Discussed back in December, I am now unconvinced this is a substantial improvement from our current statu-quo where we are pointing submitters to the archive of the full repository.

Probably something worth exploring is some tooling to generate template metadata files based on a combination of:

  • type of study (screens, experiments or both)
  • type of annotations (organism, genes, compounds...)

@sbesson sbesson closed this Jan 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants