Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove unnecessary actions/triggers #2

Merged
merged 1 commit into from
Aug 8, 2024
Merged

remove unnecessary actions/triggers #2

merged 1 commit into from
Aug 8, 2024

Conversation

suzinyou
Copy link
Contributor

@suzinyou suzinyou commented Jul 30, 2024

Reviewer: @lickem22
Estimate: 10 mins


Ticket

Fixes: -

Description

Goal

Remove actions that don't need to run.

NOTE: we may need to run git fetch public; git merge public/main at main branch

Changes

  1. Remove validation action
  2. Remove testing, main from branch trigger conditions

Checklist

Fill with x for completed.

  • My code follows the style guidelines of this project
  • I have reviewed my own code to ensure good quality
  • I have tested the functionality of my code to ensure it works as intended
  • I have resolved merge conflicts

(Delete any items below that are not relevant)

  • I have updated the automated tests
  • I have updated the scripts in scripts/
  • I have updated the requirements
  • I have updated the README file
  • I have updated affected documentation
  • I have added a blogpost in Latest Updates
  • I have updated the CI/CD scripts in .github/workflows/
  • I have updated the Terraform code

@@ -1,95 +0,0 @@
name: Retrieval validation
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you think about keeping this validation script but doing validation on the new validation data so we have an idea of the accuracy of MomConnect AAQ that after each update of the app.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That would be great!! But let's see whether/how we should prioritize it. Definitely not for v1 release :' )

Copy link
Collaborator

@lickem22 lickem22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Suzin, just left a comment!

@suzinyou suzinyou merged commit 0d2ae0f into main Aug 8, 2024
@suzinyou suzinyou deleted the cleanup-actions branch August 8, 2024 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants