Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docker compose #4

Merged
merged 3 commits into from
Aug 14, 2024
Merged

Update docker compose #4

merged 3 commits into from
Aug 14, 2024

Conversation

suzinyou
Copy link
Contributor

@suzinyou suzinyou commented Aug 13, 2024

Reviewer: @lickem22
Estimate: 10 mins


Ticket

Fixes:

Description

Goal

Publish and use MomConnect images

Changes

  1. Adds build & push scripts for admin_app and core_backend which push to our public ECR repos.

    • Copied from build-alignscore.yaml!
    • On AWS, created public ECR repositories and created new GitHub OIDC role
  2. Uses ECR URIs in docker-compose.yml, so that you can get started by running

    docker compose -f docker-compose.yml -f docker-compose.dev.yml -p aaq-stack up -d

    Notice we can just get started without --build. (Should we update this on docs?)

  3. Removes Google analytics from momconnect doc site

How has this been tested?

  • You can see that the GitHub Actions ran properly, here
  • Check out this branch, create .base.env, .core_backend.env, and .litellm_proxy.env and run the following:
    docker compose -f docker-compose.yml -f docker-compose.dev.yml -p aaq-stack up -d

To-do before merge (optional)

Checklist

Fill with x for completed.

  • My code follows the style guidelines of this project

  • I have reviewed my own code to ensure good quality

  • I have tested the functionality of my code to ensure it works as intended

  • I have resolved merge conflicts

  • I have updated affected documentation

Copy link
Collaborator

@lickem22 lickem22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @suzinyou

@lickem22 lickem22 merged commit 75d9e65 into main Aug 14, 2024
@suzinyou suzinyou deleted the update-docker-compose branch August 14, 2024 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants