Customize docs #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
suzinyou
requested review from
sidravi1,
lickem22,
amiraliemami,
Tanmay-97,
markbotterill and
tonyzhao6
as code owners
lickem22
reviewed
Aug 15, 2024
| ports: # Expose the port to port 5434 on the host machine for debugging | ||
| - 5434:5432 | ||
| ports: | ||
| - 5432:5432 |
There was a problem hiding this comment.
We didn't have to change to 5432. But I don't think it matters that much.
lickem22
reviewed
Aug 15, 2024
| @@ -12,6 +12,7 @@ services: | |||
| - .core_backend.env | |||
| environment: | |||
| - REDIS_HOST=redis://redis:6379 | |||
| - LITELLM_ENDPOINT=http://huggingface-embeddings | |||
There was a problem hiding this comment.
I don't think we should bake that in otherwise it will override the one in .core_backend.env. But they will probably have their own server and they won't user docker-compose. I will update it.
There was a problem hiding this comment.
This is so in .core_backend.env we keep values for local setup (make setup-dev), and we can override it for docker-compose only in docker-compose.yml.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reviewer: @lickem22
Estimate: 20 mins
Ticket
Fixes:
Description
Goal
Changes
Future Tasks
How has this been tested?
mkdocs serve...to review the docsChecklist
Fill with
xfor completed.(Delete any items below that are not relevant)