Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(comp:button): disabled btn when group's disabled is true #1508

Merged
merged 2 commits into from
Mar 24, 2023

Conversation

kovsu
Copy link
Member

@kovsu kovsu commented Mar 23, 2023

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines
  • Tests for the changes have been added/updated or not needed
  • Docs and demo have been added/updated or not needed

What is the current behavior?

https://playground.idux.site/#eyJQbGF5Z3JvdW5kQXBwLnZ1ZSI6Ijx0ZW1wbGF0ZT5cbiAgPEl4RHJhd2VyUHJvdmlkZXI+XG4gICAgPEl4Tm90aWZpY2F0aW9uUHJvdmlkZXI+XG4gICAgICA8SXhNb2RhbFByb3ZpZGVyPlxuICAgICAgICA8SXhNZXNzYWdlUHJvdmlkZXI+XG4gICAgICAgICAgPEFwcCAvPlxuICAgICAgICA8L0l4TWVzc2FnZVByb3ZpZGVyPlxuICAgICAgPC9JeE1vZGFsUHJvdmlkZXI+XG4gICAgPC9JeE5vdGlmaWNhdGlvblByb3ZpZGVyPlxuICA8L0l4RHJhd2VyUHJvdmlkZXI+XG48L3RlbXBsYXRlPlxuXG48c2NyaXB0IGxhbmc9XCJ0c1wiIHNldHVwPlxuaW1wb3J0IHsgc2V0dXBJZHV4IH0gZnJvbSAnLi9zZXR1cElkdXguanMnXG5pbXBvcnQgQXBwIGZyb20gJy4vQXBwLnZ1ZSdcbnNldHVwSWR1eCgpXG48L3NjcmlwdD5cbiIsIkFwcC52dWUiOiI8dGVtcGxhdGU+XG4gIDxJeEJ1dHRvbkdyb3VwIDpkaXNhYmxlZD1cIiFlbmFibGVkU3RhdHVzXCIgOmdhcD1cIjE2XCI+XG4gICAgPEl4QnV0dG9uIG1vZGU9XCJwcmltYXJ5XCIgQGNsaWNrPVwiaGFuZGxlQ2xpY2soJ1ByaW1hcnknKVwiPlByaW1hcnk8L0l4QnV0dG9uPlxuICAgIDxJeEJ1dHRvbiBAY2xpY2s9XCJoYW5kbGVDbGljaygnRGVmYXVsdCcpXCI+RGVmYXVsdDwvSXhCdXR0b24+XG4gICAgPEl4QnV0dG9uIG1vZGU9XCJkYXNoZWRcIiBAY2xpY2s9XCJoYW5kbGVDbGljaygnRGFzaGVkJylcIj5EYXNoZWQ8L0l4QnV0dG9uPlxuICAgIDxJeEJ1dHRvbiBtb2RlPVwidGV4dFwiIEBjbGljaz1cImhhbmRsZUNsaWNrKCdUZXh0JylcIj5UZXh0PC9JeEJ1dHRvbj5cbiAgICA8SXhCdXR0b24gbW9kZT1cImxpbmtcIiBAY2xpY2s9XCJoYW5kbGVDbGljaygnTGluaycpXCI+TGluazwvSXhCdXR0b24+XG4gIDwvSXhCdXR0b25Hcm91cD5cbiAgPGRpdiBzdHlsZT1cIm1hcmdpbjogMTJweFwiPlxuICAgIOeCueWHu+S6huaMiemSru+8mnt7IHRleHQgPyB0ZXh0IDogJ25vIGNsaWNrJyB9fVxuICA8L2Rpdj5cbjwvdGVtcGxhdGU+XG48c2NyaXB0IHNldHVwIGxhbmc9XCJ0c1wiPlxuICBpbXBvcnQgeyByZWYgfSBmcm9tICd2dWUnO1xuICBjb25zdCB0ZXh0ID0gcmVmKCcnKTtcbiAgY29uc3QgaGFuZGxlQ2xpY2sgPSAodHlwZTogc3RyaW5nKSA9PiB0ZXh0LnZhbHVlID0gdHlwZTtcbjwvc2NyaXB0PiJ9

What is the new behavior?

Other information

@idux-bot
Copy link

idux-bot bot commented Mar 23, 2023

This preview will be available after the AzureCI is passed.

@codecov
Copy link

codecov bot commented Mar 23, 2023

Codecov Report

Merging #1508 (b5a0855) into main (703122f) will not change coverage.
The diff coverage is 100.00%.

❗ Current head b5a0855 differs from pull request most recent head 2a953c5. Consider uploading reports for the commit 2a953c5 to get more accurate results

@@           Coverage Diff           @@
##             main    #1508   +/-   ##
=======================================
  Coverage   92.75%   92.75%           
=======================================
  Files         331      331           
  Lines       30801    30801           
  Branches     3533     3534    +1     
=======================================
  Hits        28568    28568           
  Misses       2233     2233           
Impacted Files Coverage Δ
packages/components/button/src/Button.tsx 95.37% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@danranVm danranVm merged commit 6e44b98 into IDuxFE:main Mar 24, 2023
@kovsu kovsu deleted the fix-btn-group branch March 24, 2023 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants