fix(comp:button): buttonGroup disabled not working #1510
Conversation
![cr-gpt[bot]](https://avatars.githubusercontent.com/in/292659?s=60&v=4){kind=small}
| @@ -98,7 +99,7 @@ export default defineComponent({ | |||
| ) | |||
| } | |||
| return ( | |||
| <button class={classes.value} disabled={disabled || loading} type={type} onClick={handleClick}> | |||
| <button class={classes.value} disabled={disabled.value || loading} type={type} onClick={handleClick}> | |||
| {children} | |||
| {!mergedWaveless.value && <ɵWave ref={waveRef} />} | |||
| </button> | |||
There was a problem hiding this comment.
code review:
-
In line 30 and 31, the 'disabled' variable was added to make the code more readable. This is a good practice and it should be kept.
-
The 'disabled' variable is used in line 51 and 52 to set the class of the button. This is correct and should not be changed.
-
In line 62, the 'disabled' property is used in the handleClick function to prevent click events from firing when the button is disabled or loading. This is a good practice and should be kept.
-
In line 98, the 'disabled' property is used to set the disabled attribute of the button element. This is also correct and should be kept.
|
This preview will be available after the AzureCI is passed. |
Codecov Report
@@ Coverage Diff @@
## main #1510 +/- ##
=======================================
Coverage 92.75% 92.75%
=======================================
Files 331 331
Lines 30801 30802 +1
Branches 3533 3534 +1
=======================================
+ Hits 28568 28569 +1
Misses 2233 2233
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
dup #1508 |
PR Checklist
Please check if your PR fulfills the following requirements:
What is the current behavior?
buttonGroup设置 disabled，button实际未禁用
What is the new behavior?
修复以上问题
Other information