Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(site:*): resolve vscode external links policy problem #1069

Merged
merged 1 commit into from
Aug 10, 2022

Conversation

tuchg
Copy link
Contributor

@tuchg tuchg commented Aug 10, 2022

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines
  • Tests for the changes have been added/updated or not needed
  • Docs and demo have been added/updated or not needed

What is the current behavior?

vscode侧跳转,#被vscode安全转义为%23导致site无法定位,因而重定向到首页

What is the new behavior?

路由导航中的 %23 会替换为 #,而后重定向

Other information

@idux-bot
Copy link

idux-bot bot commented Aug 10, 2022

This preview will be available after the AzureCI is passed.

@tuchg tuchg linked an issue Aug 10, 2022 that may be closed by this pull request
1 task
@codecov
Copy link

codecov bot commented Aug 10, 2022

Codecov Report

Merging #1069 (a89cd8c) into main (8c670d0) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1069   +/-   ##
=======================================
  Coverage   93.62%   93.62%           
=======================================
  Files         314      314           
  Lines       30243    30243           
  Branches     3547     3547           
=======================================
  Hits        28314    28314           
  Misses       1929     1929           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@danranVm danranVm merged commit 806460f into IDuxFE:main Aug 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[other:*] vscode自动关联idux文档;做到代码即文档
2 participants