Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(comp:table): the scroll body is incorrect, when virtual enabled #1175

Merged
merged 1 commit into from
Sep 29, 2022

Conversation

danranVm
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines
  • Tests for the changes have been added/updated or not needed
  • Docs and demo have been added/updated or not needed

What is the current behavior?

表格开启 virtual 和 列固定后, 重新加载数据 fixed 效果没了, 要重新拖动滚动条才能重新出现

原因是因为开启虚拟滚动后,scroll body 拿错了。

What is the new behavior?

Other information

@idux-bot
Copy link

idux-bot bot commented Sep 29, 2022

This preview will be available after the AzureCI is passed.

@codecov
Copy link

codecov bot commented Sep 29, 2022

Codecov Report

Merging #1175 (59e4ba5) into main (aedf5d8) will increase coverage by 0.71%.
The diff coverage is 100.00%.

❗ Current head 59e4ba5 differs from pull request most recent head 823165c. Consider uploading reports for the commit 823165c to get more accurate results

@@            Coverage Diff             @@
##             main    #1175      +/-   ##
==========================================
+ Coverage   96.18%   96.90%   +0.71%     
==========================================
  Files         317      317              
  Lines       30783    30783              
  Branches     2730     2807      +77     
==========================================
+ Hits        29609    29830     +221     
+ Misses       1174      953     -221     
Impacted Files Coverage Δ
packages/components/table/src/Table.tsx 100.00% <100.00%> (ø)
packages/components/tree/src/Tree.tsx 100.00% <100.00%> (ø)
packages/cdk/forms/src/utils.ts 75.44% <0.00%> (+3.59%) ⬆️
packages/cdk/forms/src/useForms.ts 100.00% <0.00%> (+5.37%) ⬆️
packages/cdk/forms/src/typeof.ts 100.00% <0.00%> (+8.33%) ⬆️
packages/cdk/forms/src/controls.ts 99.80% <0.00%> (+19.27%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@danranVm danranVm merged commit 295c9ad into IDuxFE:main Sep 29, 2022
@danranVm danranVm deleted the fix-table-scroll branch September 29, 2022 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants