Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(comp:stepper): change dot prop to lineStyle and support css style #1396

Closed
wants to merge 2 commits into from
Closed

feat(comp:stepper): change dot prop to lineStyle and support css style #1396

wants to merge 2 commits into from

Conversation

kovsu
Copy link
Member

@kovsu kovsu commented Jan 10, 2023

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines
  • Tests for the changes have been added/updated or not needed
  • Docs and demo have been added/updated or not needed

What is the current behavior?

close #1082

What is the new behavior?

image

Other information

@idux-bot
Copy link

idux-bot bot commented Jan 10, 2023

This preview will be available after the AzureCI is passed.

@codecov
Copy link

codecov bot commented Jan 10, 2023

Codecov Report

Merging #1396 (7e40170) into main (da3905e) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #1396   +/-   ##
=======================================
  Coverage   92.89%   92.89%           
=======================================
  Files         325      325           
  Lines       29893    29899    +6     
  Branches     2488     2488           
=======================================
+ Hits        27768    27774    +6     
  Misses       2125     2125           
Impacted Files Coverage Δ
packages/components/stepper/src/Stepper.tsx 96.15% <100.00%> (+0.07%) ⬆️
packages/components/stepper/src/types.ts 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@kovsu
Copy link
Member Author

kovsu commented Jan 11, 2023

我的想法是既然有 dotted,那为什么不也加一个 dashed。所以我删掉了 dot 属性,添加了一个 lineStyle 属性

@kovsu
Copy link
Member Author

kovsu commented Jan 11, 2023

KK WIC~1`@AYNFTYH3ZMS1Y

在添加这个属性的时候发现,上面图片这个问题。然后修复了这个问题。

@kovsu
Copy link
Member Author

kovsu commented Jan 11, 2023

然后还发现一个问题就是,竖直的步骤条 添加 labelPlacment 属性,值为 bottom 时,显示会出现问题。
image

@kovsu kovsu changed the title feat(comp:stepper): add dot prop and support css style feat(comp:stepper): change dot prop to lineStyle and support css style Jan 11, 2023
@danranVm
Copy link
Member

danranVm commented Jan 11, 2023

@kovsu 十分感谢你的 PR, 不过你理解错了这个 dot props 的意思了。

应该是下面这种的,不过我们设计规范中,这个线确实是虚线,你可以直接改成虚线。

image

@kovsu
Copy link
Member Author

kovsu commented Jan 11, 2023

@kovsu 十分感谢你的 PR, 不过你理解错了这个 dot props 的意思了。

应该是下面这种的,不过我们设计规范中,这个线确实是虚线,你可以直接改成虚线。

image

噢,那我等下再去 修改一下,在提交,可以吗

@danranVm
Copy link
Member

@kovsu 十分感谢你的 PR, 不过你理解错了这个 dot props 的意思了。
应该是下面这种的,不过我们设计规范中,这个线确实是虚线,你可以直接改成虚线。
image

噢,那我等下再去 修改一下,在提交,可以吗

当然可以,非常欢迎一起参与。

@danranVm
Copy link
Member

对了,修改完代码后,你应该需要在本地执行一下 npm test -- -u 来更新一下测试快照,因为你需要新增 class 的话,会跟之前的快照不一致。

@kovsu
Copy link
Member Author

kovsu commented Jan 11, 2023

对了,修改完代码后,你应该需要在本地执行一下 npm test -- -u 来更新一下测试快照,因为你需要新增 class 的话,会跟之前的快照不一致。

好的

@kovsu
Copy link
Member Author

kovsu commented Jan 11, 2023

对了,修改完代码后,你应该需要在本地执行一下 npm test -- -u 来更新一下测试快照,因为你需要新增 class 的话,会跟之前的快照不一致。

我重新开个 pr 吧,这个我先关了

@kovsu kovsu closed this Jan 11, 2023
@kovsu kovsu deleted the stepper-dot branch January 11, 2023 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[comp:stepper] dot 属性无用
2 participants