-
Notifications
You must be signed in to change notification settings - Fork 140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(comp:stepper): change dot prop to lineStyle and support css style #1396
Conversation
This preview will be available after the AzureCI is passed. |
Codecov Report
@@ Coverage Diff @@
## main #1396 +/- ##
=======================================
Coverage 92.89% 92.89%
=======================================
Files 325 325
Lines 29893 29899 +6
Branches 2488 2488
=======================================
+ Hits 27768 27774 +6
Misses 2125 2125
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
我的想法是既然有 dotted,那为什么不也加一个 dashed。所以我删掉了 dot 属性,添加了一个 lineStyle 属性 |
@kovsu 十分感谢你的 PR, 不过你理解错了这个 dot props 的意思了。 应该是下面这种的,不过我们设计规范中,这个线确实是虚线,你可以直接改成虚线。 |
噢,那我等下再去 修改一下,在提交,可以吗 |
当然可以,非常欢迎一起参与。 |
对了,修改完代码后,你应该需要在本地执行一下 |
好的 |
我重新开个 pr 吧,这个我先关了 |
PR Checklist
Please check if your PR fulfills the following requirements:
What is the current behavior?
close #1082
What is the new behavior?
Other information