-
Notifications
You must be signed in to change notification settings - Fork 140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(comp:stepper): add dot prop #1401
Conversation
This preview will be available after the AzureCI is passed. |
Codecov Report
@@ Coverage Diff @@
## main #1401 +/- ##
=======================================
Coverage 92.89% 92.90%
=======================================
Files 325 325
Lines 29919 29931 +12
Branches 2494 2495 +1
=======================================
+ Hits 27794 27806 +12
Misses 2125 2125
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
另外记得更新一下测试快照, 不然 CI 过不了。
return normalizeClass({ | ||
[prefixCls]: true, | ||
[`${prefixCls}-${status.value}`]: true, | ||
[`${prefixCls}-active`]: isActive.value, | ||
[`${prefixCls}-clickable`]: parentProps.clickable && !disabled, | ||
[`${prefixCls}-disabled`]: disabled, | ||
[`${prefixCls}-with-icon`]: icon || !!slots.icon, | ||
[`${prefixCls}-dot`]: dot, | ||
[`${prefixCls}-label-${labelPlacement}`]: true, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[`${prefixCls}-label-${labelPlacement}`]: true, |
这个似乎不用加 ? 父组件已经有这个 class 了。
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这个似乎不用加 ? 父组件已经有这个 class 了。
我加这个是想着 css 里面可以嵌套在 那个 .ix-stepper-item 里面写,就不用去 .ix-stepper 里面去写。然后我用 npm run test -u,它好像更新了所有测试的快照
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
更新了所有测试的快照?是不是你的依赖版本比较低? 删除 node-modules 和 pnpm-lock 文件重新 install 一下再跑一下试试呢?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
了所有测试的快照?是不是你的依赖版本比较低? 删除 node-modules 和
ok,我去试一下
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
命令应该是 npm run test -- -u
最开始的想法是可以用一个插槽搞定自定义所有的点(根据 Key 的不同去),而不用在每个 Item 里都写一遍 <IxStepper>
<IxStepperItem title="Finished"></IxStepperItem>
<IxStepperItem title="In Progress"></IxStepperItem>
<IxStepperItem title="Waiting"></IxStepperItem>
<template #dot={key}>
<div v-if="key===1"></div>
</template>
</IxStepper> 不过刚刚想了下,似乎确实也不太合理,暂时就不支持插槽吧,你把文档改一下吧,删掉 |
@kovsu 测试快照的话,上面有回复你。 |
|
可能是因为 windows 系统的文件结束符导致的? 你就把你 add 的这两个文件提交吧。 |
ok 谢谢了啊😀 |
git config --global core.autocrlf input |
好的,我配置一下。谢谢 : -) |
PR Checklist
Please check if your PR fulfills the following requirements:
What is the current behavior?
What is the new behavior?
Other information