Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(comp:text): expand icon shouldn't render when not ellipsised #1699

Merged

Conversation

sallerli1
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines
  • Tests for the changes have been added/updated or not needed
  • Docs and demo have been added/updated or not needed

What is the current behavior?

在文字没有被省略的时候,展开收起按钮依然会被渲染

What is the new behavior?

修复以上问题

Other information

@idux-bot
Copy link

idux-bot bot commented Sep 20, 2023

This preview will be available after the AzureCI is passed.

@codecov
Copy link

codecov bot commented Sep 20, 2023

Codecov Report

Merging #1699 (405d233) into main (b03eadd) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

❗ Current head 405d233 differs from pull request most recent head 915e531. Consider uploading reports for the commit 915e531 to get more accurate results

@@            Coverage Diff             @@
##             main    #1699      +/-   ##
==========================================
- Coverage   92.55%   92.54%   -0.01%     
==========================================
  Files         345      345              
  Lines       32421    32421              
  Branches     3693     3693              
==========================================
- Hits        30007    30005       -2     
- Misses       2414     2416       +2     
Files Changed Coverage Δ
packages/components/text/src/Text.tsx 81.42% <100.00%> (-1.10%) ⬇️

@sallerli1 sallerli1 force-pushed the fix-text-expand-when-not-ellipsised branch from 992dcc9 to 915e531 Compare September 25, 2023 03:22
@sallerli1 sallerli1 merged commit 43d489b into IDuxFE:main Sep 25, 2023
7 checks passed
@sallerli1 sallerli1 deleted the fix-text-expand-when-not-ellipsised branch July 4, 2024 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant