Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(comp: backtop): add backtop component (#79) #185

Merged
merged 1 commit into from
Feb 5, 2021
Merged

feat(comp: backtop): add backtop component (#79) #185

merged 1 commit into from
Feb 5, 2021

Conversation

imguolao
Copy link
Contributor

@imguolao imguolao commented Feb 2, 2021

fix #79

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines
  • Tests for the changes have been added/updated or not needed
  • Docs and demo have been added/updated or not needed

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Component style update
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Application (the showcase website) / infrastructure changes
  • Other... Please describe:

What is the current behavior?

What is the new behavior?

Other information

@imguolao
Copy link
Contributor Author

imguolao commented Feb 2, 2021

@danranVm @huangtenghui need review.

@codecov
Copy link

codecov bot commented Feb 2, 2021

Codecov Report

Merging #185 (deabe66) into main (b6d178c) will increase coverage by 0.14%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #185      +/-   ##
==========================================
+ Coverage   95.88%   96.03%   +0.14%     
==========================================
  Files          74       76       +2     
  Lines        1557     1614      +57     
  Branches      265      275      +10     
==========================================
+ Hits         1493     1550      +57     
  Misses         33       33              
  Partials       31       31              
Impacted Files Coverage Δ
packages/components/icon/src/icons.ts 100.00% <ø> (ø)
packages/components/back-top/src/BackTop.vue 100.00% <100.00%> (ø)
packages/components/core/config/defaultConfig.ts 100.00% <100.00%> (ø)
...es/components/icon/definitions/verticalAlignTop.ts 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b6d178c...deabe66. Read the comment docs.

packages/components/back-top/__test__/backTop.spec.ts Outdated Show resolved Hide resolved
packages/components/back-top/docs/index.zh.md Outdated Show resolved Hide resolved
packages/components/back-top/src/BackTop.vue Outdated Show resolved Hide resolved
packages/components/back-top/src/BackTop.vue Outdated Show resolved Hide resolved
packages/components/back-top/src/BackTop.vue Outdated Show resolved Hide resolved
packages/components/back-top/src/BackTop.vue Outdated Show resolved Hide resolved
packages/components/back-top/src/BackTop.vue Outdated Show resolved Hide resolved
packages/components/back-top/src/BackTop.vue Outdated Show resolved Hide resolved
packages/components/back-top/style/index.less Show resolved Hide resolved
packages/components/style/default.less Outdated Show resolved Hide resolved
packages/components/back-top/style/index.less Outdated Show resolved Hide resolved
Copy link
Member

@danranVm danranVm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@danranVm danranVm merged commit 1472abd into IDuxFE:main Feb 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[comp: BackTop] add BackTop component
2 participants