Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(comp:modal): draggable of modal with custom header slot doesn't work #1970

Merged
merged 1 commit into from
Jul 30, 2024

Conversation

sallerli1
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines
  • Tests for the changes have been added/updated or not needed
  • Docs and demo have been added/updated or not needed

What is the current behavior?

具有 header 插槽的modal 组件,开启 draggable,拖拽不生效

What is the new behavior?

修复以上问题

Other information

  1. 私有的 header 组件返回的vnode可能不是最终渲染的vnode,改用 getFirstValidVnode 获取第一个可用的vnode
  2. header 组件的 header 插槽不再支持多节点组件

Copy link

idux-bot bot commented Jul 23, 2024

This preview will be available after the AzureCI is passed.

Copy link

codecov bot commented Jul 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.95%. Comparing base (4e5cdcc) to head (67882ab).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1970   +/-   ##
=======================================
  Coverage   90.95%   90.95%           
=======================================
  Files         358      358           
  Lines       35691    35691           
  Branches     3889     3888    -1     
=======================================
  Hits        32463    32463           
  Misses       3228     3228           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sallerli1 sallerli1 merged commit e5ecfc5 into IDuxFE:main Jul 30, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant