Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(comp:i18n): support i18n #60

Merged
merged 1 commit into from
Dec 23, 2020
Merged

feat(comp:i18n): support i18n #60

merged 1 commit into from
Dec 23, 2020

Conversation

danranVm
Copy link
Member

fix #59

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines
  • Tests for the changes have been added/updated or not needed
  • Docs and demo have been added/updated or not needed

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Component style update
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Application (the showcase website) / infrastructure changes
  • Other... Please describe:

What is the current behavior?

What is the new behavior?

Other information

@codecov
Copy link

codecov bot commented Dec 22, 2020

Codecov Report

Merging #60 (f1f3288) into main (8326e40) will increase coverage by 1.06%.
The diff coverage is 95.65%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #60      +/-   ##
==========================================
+ Coverage   92.63%   93.70%   +1.06%     
==========================================
  Files          36       39       +3     
  Lines         258      270      +12     
  Branches       36       39       +3     
==========================================
+ Hits          239      253      +14     
+ Misses          9        7       -2     
  Partials       10       10              
Impacted Files Coverage Δ
packages/components/icon/src/utils.ts 82.08% <0.00%> (ø)
packages/components/i18n/languages/en_US.ts 100.00% <100.00%> (ø)
packages/components/i18n/languages/es_ES.ts 100.00% <100.00%> (ø)
packages/components/i18n/languages/zh_CN.ts 100.00% <100.00%> (ø)
packages/components/i18n/languages/zh_TW.ts 100.00% <100.00%> (ø)
packages/components/i18n/useI18n.ts 100.00% <100.00%> (ø)
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8326e40...f1f3288. Read the comment docs.

Copy link
Member

@coolyuantao coolyuantao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

按讨论的结论:

  1. 组件库内部只提供简单的文本,不应该存在字符拼接这些场景
  2. 表单提示另外封装
  3. 后面再提供一些简单的封装帮助业务更好使用

@danranVm danranVm merged commit 0b6a03a into IDuxFE:main Dec 23, 2020
@danranVm danranVm deleted the feat-i18n branch December 23, 2020 02:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[comp: i18n] support i18n
3 participants